ash: Make the buttons in the tray-popup headers accessible from keyboard.

ash: Make the buttons in the tray-popup headers accessible from keyboard.

BUG=124864
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133780

[Ben Goodger (Google), 2012-04-24 21:18:08]

LGTM

On Tue, Apr 24, 2012 at 1:08 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: Make the buttons in the tray-popup headers accessible from keyboard.
>
> BUG=124864
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/10218002/<http://codereview.chromium.org/102...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/system/tray/tray_views.h
>  M ash/system/tray/tray_views.cc
>
>
> Index: ash/system/tray/tray_views.cc
> diff --git a/ash/system/tray/tray_views.**cc b/ash/system/tray/tray_views.
> **cc
> index e27814016483dc7d01477bded2d944**5318bc496e..**
> 99efb4e6971bbe001f90ce83dddbe9**30b5765730 100644
> --- a/ash/system/tray/tray_views.**cc
> +++ b/ash/system/tray/tray_views.**cc
> @@ -292,6 +292,7 @@ TrayPopupHeaderButton::**TrayPopupHeaderButton(views::
> **ButtonListener* listener,
>                     views::ImageButton::ALIGN_**MIDDLE);
>   set_background(views::**Background::**CreateSolidBackground(
>       ash::kHeaderBackgroundColor));
> +  set_focusable(true);
>  }
>
>  TrayPopupHeaderButton::~**TrayPopupHeaderButton() {}
> @@ -305,6 +306,13 @@ void TrayPopupHeaderButton::**OnPaintBorder(gfx::Canvas*
> canvas) {
>   canvas->FillRect(gfx::Rect(0, 0, 1, height()), ash::kBorderDarkColor);
>  }
>
> +void TrayPopupHeaderButton::**OnPaintFocusBorder(gfx::**Canvas* canvas) {
> +  if (HasFocus() && (focusable() || IsAccessibilityFocusable())) {
> +    canvas->DrawRect(gfx::Rect(2, 1, width() - 4, height() - 3),
> +                     kFocusBorderColor);
> +  }
> +}
> +
>  void TrayPopupHeaderButton::**StateChanged() {
>   set_background(views::**Background::**CreateSolidBackground(
>       IsHotTracked() ? ash::**kHeaderHoverBackgroundColor :
> Index: ash/system/tray/tray_views.h
> diff --git a/ash/system/tray/tray_views.h b/ash/system/tray/tray_views.h
> index 96e476c22d11651edbc2578f2e41dc**ca30ccc442..**
> fe733bf45e4793b76af19dec76b349**5ce8a0b631 100644
> --- a/ash/system/tray/tray_views.h
> +++ b/ash/system/tray/tray_views.h
> @@ -191,6 +191,7 @@ class TrayPopupHeaderButton : public
> views::ToggleImageButton {
>   // Overridden from views::View.
>   virtual gfx::Size GetPreferredSize() OVERRIDE;
>   virtual void OnPaintBorder(gfx::Canvas* canvas) OVERRIDE;
> +  virtual void OnPaintFocusBorder(gfx::**Canvas* canvas) OVERRIDE;
>
>   // Overridden from views::CustomButton.
>   virtual void StateChanged() OVERRIDE;
>
>
>