tools/json_schema_compiler/cc_generator.py - Issue 10217018: Alarm resolution changed to minutes and minimum delay added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 10217018: Alarm resolution changed to minutes and minimum delay added. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Made ValidateDelayTime global and used GetExtension instead. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index eaf6fb3e6e48dcc9f2e4e2c4308676ab36e654bf..049cb65b2288a0968729349e2a02b7d39b9f2c12 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -455,12 +455,6 @@ class CCGenerator(object):

c = Code()

c.Sblock('{')

- if check_type and prop.type_ not in (

- PropertyType.CHOICES, PropertyType.ANY):

- (c.Append('if (!%(value_var)s->IsType(%(value_type)s))')

- .Append(' return %(failure_value)s;')

- )

if prop.type_.is_fundamental:

if prop.optional:

(c.Append('%(ctype)s temp;')