chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 10217017: Allow features to refer to subkeys in _manifest_features.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 10217017: Allow features to refer to subkeys in _manifest_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix theme test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index fe4cb71e3ef4c7d0d72a1a61213c7dc9eb578fb9..ca600ed4eb14c1e050408f663008b5e01abee8b2 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -28,10 +28,13 @@ TEST_F(ExtensionManifestTest, PlatformApps) {

LoadAndExpectError(

"init_invalid_platform_app_2.json",

extension_manifest_errors::kBackgroundRequiredForPlatformApps);

- LoadAndExpectError(

- "init_invalid_platform_app_3.json",

- "Feature 'platform_app' is not accessible. "

- "'platform_app' requires manifest version of at least 2.");

+ scoped_refptr<Extension> extension =

+ LoadAndExpectSuccess("init_invalid_platform_app_3.json");

+ ASSERT_TRUE(extension);

+ ASSERT_EQ(1u, extension->install_warnings().size());

+ EXPECT_EQ("'platform_app' requires manifest version of at least 2.",

+ extension->install_warnings()[0]);

}

TEST_F(ExtensionManifestTest, CertainApisRequirePlatformApps) {