chrome/common/extensions/manifest.h - Issue 10217017: Allow features to refer to subkeys in _manifest_features.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest.h

Issue 10217017: Allow features to refer to subkeys in _manifest_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix theme test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest.h

diff --git a/chrome/common/extensions/manifest.h b/chrome/common/extensions/manifest.h

index 43e2caa03127b1421e3067b855372f3e8bb6d20e..844ca497254598417456cf53ed8a218576f8656e 100644

--- a/chrome/common/extensions/manifest.h

+++ b/chrome/common/extensions/manifest.h

@@ -33,7 +33,7 @@ class Manifest {

// Returns true if all keys in the manifest can be specified by

// the extension type.

- bool ValidateManifest(string16* error) const;

+ void ValidateManifest(std::vector<std::string>* warnings) const;

// The version of this extension's manifest. We increase the manifest

// version when making breaking changes to the extension system. If the