Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/app/theme/theme_resources_standard.grd

Issue 10217014: Ash: New assets for toolbar icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/theme_resources_metro_1x.grd ('k') | ui/resources/aura/textbutton_hot_bottom.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/theme/theme_resources_standard.grd
diff --git a/chrome/app/theme/theme_resources_standard.grd b/chrome/app/theme/theme_resources_standard.grd
index 7da76e2d016937fa9ef5183505e9235fcb5a4094..1b84aee25c36ef4bfa93c6d757fac8fea5befc6d 100644
--- a/chrome/app/theme/theme_resources_standard.grd
+++ b/chrome/app/theme/theme_resources_standard.grd
@@ -206,10 +206,21 @@
<include name="IDR_TAB_ALPHA_LEFT" file="tab_alpha_left.png" type="BINDATA" />
<include name="IDR_TAB_ALPHA_RIGHT" file="tab_alpha_right.png" type="BINDATA" />
</if>
- <include name="IDR_TAB_CLOSE" file="tab_close.png" type="BINDATA" />
- <include name="IDR_TAB_CLOSE_H" file="tab_close_h.png" type="BINDATA" />
- <include name="IDR_TAB_CLOSE_MASK" file="tab_close_mask.png" type="BINDATA" />
- <include name="IDR_TAB_CLOSE_P" file="tab_close_p.png" type="BINDATA" />
+ <!-- Note: Tab close buttons are not traditional buttons. Tab close buttons
+ fill a background with a color from the theme, tile IDR_TAB_CLOSE over it,
+ then apply IDR_TAB_CLOSE_MASK. See chrome/browser/ui/views/tabs/tab.cc -->
+ <if expr="pp_ifdef('use_ash')">
+ <include name="IDR_TAB_CLOSE" file="ash/tab_close_normal.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_H" file="ash/tab_close_hot.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_MASK" file="ash/tab_close_mask.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_P" file="ash/tab_close_pressed.png" type="BINDATA" />
+ </if>
+ <if expr="not pp_ifdef('use_ash')">
+ <include name="IDR_TAB_CLOSE" file="tab_close.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_H" file="tab_close_h.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_MASK" file="tab_close_mask.png" type="BINDATA" />
+ <include name="IDR_TAB_CLOSE_P" file="tab_close_p.png" type="BINDATA" />
+ </if>
<include name="IDR_TAB_DROP_DOWN" file="tab_drop_down.png" type="BINDATA" />
<include name="IDR_TAB_DROP_UP" file="tab_drop_up.png" type="BINDATA" />
<if expr="pp_ifdef('use_ash')">
@@ -223,10 +234,10 @@
<include name="IDR_TAB_INACTIVE_RIGHT" file="tab_inactive_right.png" type="BINDATA" />
</if>
<if expr="pp_ifdef('use_ash')">
- <include name="IDR_THEME_FRAME" file="ash/theme_frame.png" type="BINDATA" />
- <include name="IDR_THEME_FRAME_INACTIVE" file="ash/theme_frame_inactive.png" type="BINDATA" />
- <include name="IDR_THEME_FRAME_INCOGNITO" file="ash/theme_frame_incognito.png" type="BINDATA" />
- <include name="IDR_THEME_FRAME_INCOGNITO_INACTIVE" file="ash/theme_frame_incognito_inactive.png" type="BINDATA" />
+ <include name="IDR_THEME_FRAME" file="ash/theme_default_active.png" type="BINDATA" />
+ <include name="IDR_THEME_FRAME_INACTIVE" file="ash/theme_default_inactive.png" type="BINDATA" />
+ <include name="IDR_THEME_FRAME_INCOGNITO" file="ash/theme_incognito_active.png" type="BINDATA" />
+ <include name="IDR_THEME_FRAME_INCOGNITO_INACTIVE" file="ash/theme_incognito_inactive.png" type="BINDATA" />
</if>
<if expr="not pp_ifdef('use_ash')">
<include name="IDR_THEME_FRAME" file="theme_frame.png" type="BINDATA" />
« no previous file with comments | « chrome/app/theme/theme_resources_metro_1x.grd ('k') | ui/resources/aura/textbutton_hot_bottom.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698