Issue 10217005: Revert back to using WaitUntil for page readyState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10217005: Revert back to using WaitUntil for page readyState (Closed)

Created:
8 years, 8 months ago by dyu1

Modified:
8 years, 8 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert back to using WaitUntil for page readyState until tests using WaitUntilNavigationCompletes() can be determined. TEST=none BUG=124877 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133751

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/test/functional/infobars.py	View		1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dyu1

The one-click infobar tests are failing on linux and mac machines only. All the errors ...

8 years, 8 months ago (2012-04-24 20:11:36 UTC) #1

Nirnimesh

8 years, 8 months ago (2012-04-24 20:13:09 UTC) #2

LGTM

http://codereview.chromium.org/10217005/diff/1/chrome/test/functional/infobar...
File chrome/test/functional/infobars.py (right):

http://codereview.chromium.org/10217005/diff/1/chrome/test/functional/infobar...
chrome/test/functional/infobars.py:213:
#self.WaitUntilNavigationCompletes(tab_index=tab_index, windex=windex)
remove commented out code. the TODO is fine.

Expand Messages | Collapse Messages