Get rid of overloaded toDartValue.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import re
-import string
 
 _pure_interfaces = set([
     'DOMStringMap',
     'ElementTimeControl',
     'ElementTraversal',
     'MediaQueryListListener',
     'NodeSelector',
     'SVGExternalResourcesRequired',
     'SVGFilterPrimitiveStandardAttributes',
     'SVGFitToViewBox',
@@ skipping 515 matching lines @@
       return 'const String&'
     return self.native_type()
 
   def conversion_includes(self):
     return []
 
   def to_dart_conversion(self, value, interface_name=None, attributes=None):
     conversion_arguments = [value]
     if attributes and 'TreatReturnedNullStringAs' in attributes:
       conversion_arguments.append('DartUtilities::ConvertNullToDefaultValue')
-    function_name = 'toDartValue'
-    # FIXME: implement DartUtilities::toDart for other primitive types and
-    # remove this list.
-    if self.native_type() in ['String', 'bool', 'int', 'unsigned', 'long long', 'unsigned long long', 'double']:
-      function_name = string.capwords(self.native_type()).replace(' ', '')
-      function_name = function_name[0].lower() + function_name[1:]
-      function_name = 'DartUtilities::%sToDart' % function_name
+    function_name = re.sub(r' [a-z]', lambda x: x.group(0)[1:].upper(), self.native_type())

[Anton Muhin, 2012/04/25 10:05:18]

nit.

I am probably biased here, but is it more readable?

If you hate capwords, maybe something like:

parts = self.native_type().split()
type = parts[0] + ''.join((s.capitalize() for s in parts[1:]))

?

[podivilov, 2012/04/25 11:12:58]

I've changed this logic for ScriptValue -> scriptValueToDart case. Capitalize is
doing the wrong thing.

[Anton Muhin, 2012/04/25 13:09:55]

I see, thanks for explanations.

Still maybe: def capitalize(s): return s[0].upper() + s[1:]?

Up to you.

On 2012/04/25 11:12:58, podivilov wrote:

+    function_name = function_name[0].lower() + function_name[1:]
+    function_name = 'DartUtilities::%sToDart' % function_name
     return '%s(%s)' % (function_name, ', '.join(conversion_arguments))
 
   def webcore_getter_name(self):
     return self._webcore_getter_name
 
   def webcore_setter_name(self):
     return self._webcore_setter_name
 
 class SVGTearOffIDLTypeInfo(IDLTypeInfo):
   def __init__(self, idl_type, native_type='', ref_counted=True):
@@ skipping 115 matching lines @@
     '"SVGAnimatedListPropertyTearOff.h"',
     '"SVGTransformListPropertyTearOff.h"',
     '"SVGPathSegListPropertyTearOff.h"',
 ]
 
 def GetIDLTypeInfo(idl_type_name):
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
   return _idl_type_registry.get(idl_type_name, IDLTypeInfo(idl_type_name))