Issue 10217001: Add field names to Code, ConsString, and JSGlobalPropertyCell in heap snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10217001: Add field names to Code, ConsString, and JSGlobalPropertyCell in heap snapshot. (Closed)

Created:
8 years, 8 months ago by alexeif

Modified:
8 years, 8 months ago

Reviewers:
mnaganov (inactive), yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add field names to Code, ConsString, and JSGlobalPropertyCell in heap snapshot. Committed: https://code.google.com/p/v8/source/detail?r=11430

Patch Set 2 : Addressing comments. #

Patch Set 3 : Fixed bad wrapping. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -33 lines)			Patch
	M	src/profile-generator.h	View	1 2	1 chunk	+12 lines, -9 lines	0 comments	Download
	M	src/profile-generator.cc	View	1 2	9 chunks	+51 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://chromiumcodereview.appspot.com/10217001/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10217001/diff/1/src/profile-generator.cc#newcode2233 src/profile-generator.cc:2233: TagObject(code->unchecked_relocation_info(), "(code relocation info)"); btw, why we use ...

8 years, 8 months ago (2012-04-25 06:26:16 UTC) #2

alexeif

https://chromiumcodereview.appspot.com/10217001/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10217001/diff/1/src/profile-generator.cc#newcode2233 src/profile-generator.cc:2233: TagObject(code->unchecked_relocation_info(), "(code relocation info)"); On 2012/04/25 06:26:16, Yury Semikhatsky ...

8 years, 8 months ago (2012-04-25 09:55:10 UTC) #3

lgtm