Issue 10216003: Split out binary file from the content shell CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10216003: Split out binary file from the content shell CL. (Closed)

Created:
8 years, 8 months ago by Ted C

Modified:
8 years, 8 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split out binary file from the content shell CL. Necessary to make it pass the try-bots, which don't support binary files. When generating an android APK, it uses all the files in the res/ directory and generates a R.java which contains resource IDs to be referenced in the code, so a missing file will result in a missing ID reference and non-compiling code. BUG=118591 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133771

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	A	content/shell/android/res/drawable-nodpi/popup_zoomer_overlay.9.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10216003/1

8 years, 8 months ago (2012-04-24 21:18:54 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-24 21:22:19 UTC) #4

Try job failure for 10216003-1 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages