Issue 10215001: Fix SelectFileDialogExtensionBrowserTest.SelectFileAndSave javascript error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10215001: Fix SelectFileDialogExtensionBrowserTest.SelectFileAndSave javascript error. (Closed)

Created:
8 years, 8 months ago by flackr

Modified:
8 years, 8 months ago

Reviewers:
Oleg Eterevsky

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix SelectFileDialogExtensionBrowserTest.SelectFileAndSave javascript error. The SelectFileAndSave test was failing on linux chromiumos browsertests since r133663. This seems to be due to a name mismatch in the CL which renamed a method isFilterHiddenOn but attempted to call it as getFilterHidden. See https://chromiumcodereview.appspot.com/10206015. TBR=oleg BUG=None TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndSave Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133730

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM
Thanks for looking into this.

Expand Messages | Collapse Messages