Don't register or use the DelegateExecute verb handler if it isn't present.

chrome/installer/util/shell_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines functions that integrate Chrome in Windows shell. These
 // functions can be used by Chrome as well as Chrome installer. All of the
 // work is done by the local functions defined in anonymous namespace in
 // this class.
 
 #include "chrome/installer/util/shell_util.h"
@@ skipping 71 matching lines @@
                                const string16& chrome_exe,
                                const string16& suffix,
                                std::list<RegistryEntry*>* entries) {
     string16 icon_path(ShellUtil::GetChromeIcon(dist, chrome_exe));
     string16 open_cmd(ShellUtil::GetChromeShellOpenCmd(chrome_exe));
     string16 delegate_command(ShellUtil::GetChromeDelegateCommand(chrome_exe));
     // For user-level installs: entries for the app id and DelegateExecute verb
     // handler will be in HKCU; thus we do not need a suffix on those entries.
     string16 app_id(dist->GetBrowserAppId());
     string16 delegate_guid;
+    // TODO(grt): remove HasDelegateExecuteHandler when the exe is ever-present;
+    // see also install_worker.cc's AddDelegateExecuteWorkItems.
     bool set_delegate_execute =
-        base::win::GetVersion() >= base::win::VERSION_WIN8 &&
-        dist->GetDelegateExecuteHandlerData(&delegate_guid, NULL, NULL, NULL);
+        dist->GetDelegateExecuteHandlerData(&delegate_guid, NULL, NULL, NULL) &&
+        InstallUtil::HasDelegateExecuteHandler(dist, chrome_exe);
 
     // DelegateExecute ProgId. Needed for Chrome Metro in Windows 8.
     if (set_delegate_execute) {
       string16 model_id_shell(ShellUtil::kRegClasses);
       model_id_shell.push_back(FilePath::kSeparators[0]);
       model_id_shell.append(app_id);
       model_id_shell.append(ShellUtil::kRegExePath);
       model_id_shell.append(ShellUtil::kRegShellPath);
 
       // <root hkey>\Software\Classes\<app_id>\.exe\shell @=open
@@ skipping 492 matching lines @@
 
 uint32 ConvertShellUtilShortcutOptionsToFileUtil(uint32 options) {
   uint32 converted_options = 0;
   if (options & ShellUtil::SHORTCUT_DUAL_MODE)
     converted_options |= file_util::SHORTCUT_DUAL_MODE;
   if (options & ShellUtil::SHORTCUT_CREATE_ALWAYS)
     converted_options |= file_util::SHORTCUT_CREATE_ALWAYS;
   return converted_options;
 }
 
+// As of r133333, the DelegateExecute verb handler was being registered for
+// Google Chrome installs on Windows 8 even though the binary itself wasn't
+// present.  This affected Chrome 20.0.1115.1 on the dev channel (and anyone who
+// pulled a Canary >= 20.0.1112.0 and installed it manually as Google Chrome).
+// This egregious hack is here to remove the bad values for those installs, and
+// should be removed after a reasonable time, say 2012-08-01.  Anyone on Win8
+// dev channel who hasn't been autoupdated or manually updated by then will have
+// to uninstall and reinstall Chrome to repair.  See http://crbug.com/124666 and
+// http://crbug.com/123994 for gory details.
+void RemoveBadWindows8RegistrationIfNeeded(
+    BrowserDistribution* dist,
+    const string16& chrome_exe,
+    const string16& suffix) {
+  string16 handler_guid;
+
+  if (dist->GetDelegateExecuteHandlerData(&handler_guid, NULL, NULL, NULL) &&
+      !InstallUtil::HasDelegateExecuteHandler(dist, chrome_exe)) {
+    // There's no need to rollback, so forgo the usual work item lists and just
+    // remove the values from the registry.
+    const HKEY root_key = InstallUtil::IsPerUserInstall(chrome_exe.c_str()) ?
+        HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;
+    const string16 app_id(dist->GetBrowserAppId());
+
+    // <root hkey>\Software\Classes\<app_id>
+    string16 key(ShellUtil::kRegClasses);
+    key.push_back(FilePath::kSeparators[0]);
+    key.append(app_id);
+    InstallUtil::DeleteRegistryKey(root_key, key);
+
+    // <root hkey>\Software\Classes\ChromiumHTML[.user]\shell\open\command
+    key = ShellUtil::kRegClasses;
+    key.push_back(FilePath::kSeparators[0]);
+    key.append(ShellUtil::kChromeHTMLProgId);
+    key.append(suffix);
+    key.append(ShellUtil::kRegShellOpen);
+    InstallUtil::DeleteRegistryValue(root_key, key,
+                                     ShellUtil::kRegDelegateExecute);
+  }
+}
+
 }  // namespace
 
 const wchar_t* ShellUtil::kRegDefaultIcon = L"\\DefaultIcon";
 const wchar_t* ShellUtil::kRegShellPath = L"\\shell";
 const wchar_t* ShellUtil::kRegShellOpen = L"\\shell\\open\\command";
 const wchar_t* ShellUtil::kRegStartMenuInternet =
     L"Software\\Clients\\StartMenuInternet";
 const wchar_t* ShellUtil::kRegClasses = L"Software\\Classes";
 const wchar_t* ShellUtil::kRegRegisteredApplications =
     L"Software\\RegisteredApplications";
@@ skipping 403 matching lines @@
   // make them unique.
   string16 suffix;
   if (!unique_suffix.empty()) {
     suffix = unique_suffix;
   } else if (InstallUtil::IsPerUserInstall(chrome_exe.c_str()) &&
              !GetUserSpecificDefaultBrowserSuffix(dist, &suffix) &&
              !AnotherUserHasDefaultBrowser(dist, chrome_exe)) {
     suffix = L"";
   }
 
+  // TODO(grt): remove this on or after 2012-08-01; see impl for details.
+  RemoveBadWindows8RegistrationIfNeeded(dist, chrome_exe, suffix);
+
   // Check if Chromium is already registered with this suffix.
   if (IsChromeRegistered(dist, chrome_exe, suffix))
     return true;
 
   // If user is an admin try to register and return the status.
   if (IsUserAnAdmin()) {
     std::list<RegistryEntry*> progids;
     STLElementDeleter<std::list<RegistryEntry*> > progids_deleter(&progids);
     std::list<RegistryEntry*> sys_entries;
     STLElementDeleter<std::list<RegistryEntry*> > sys_deleter(&sys_entries);
@@ skipping 175 matching lines @@
       chrome_exe.c_str(),
       shortcut.c_str(),
       chrome_path.c_str(),
       arguments.c_str(),
       description.c_str(),
       icon_path.c_str(),
       icon_index,
       dist->GetBrowserAppId().c_str(),
       ConvertShellUtilShortcutOptionsToFileUtil(options));
 }