Issue 10213009: Resubmit r133740: Fix homepage migration for users who never changed their settings.

Issue 10213009: Resubmit r133740: Fix homepage migration for users who never changed their settings. (Closed)

Created:
8 years, 8 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 8 months ago

Reviewers:
csilv, Mattias Nissler (ping if slow), Ben Goodger (Google), Ivan Korotkov, Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Resubmit r133740: Fix homepage migration for users who never changed their settings. BUG=122936 TEST=Upgrade from 18 to 19 TBR=ivankr@chromium.org,nirnimesh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134147

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -27 lines)			Patch
M	chrome/browser/prefs/pref_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_service.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/session_startup_pref.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/session_startup_pref.cc	View	1	4 chunks	+56 lines, -14 lines	1 comment	Download
M	chrome/browser/prefs/session_startup_pref_unittest.cc	View	1	3 chunks	+73 lines, -0 lines	0 comments	Download
M	chrome/browser/protector/protected_prefs_watcher.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/test/functional/protector.py	View		4 chunks	+73 lines, -6 lines	0 comments	Download

Total messages: 7 (0 generated)

Tyler Breisacher (Chromium)

In an effort to make this easier to review, patch set 1 is identical to ...

8 years, 8 months ago (2012-04-24 21:27:22 UTC) #1

csilv

thanks for separating out the changes, that is super helpful. lgtm

8 years, 8 months ago (2012-04-24 23:23:14 UTC) #3

Tyler Breisacher (Chromium)

+mnissler for the new change in SessionStartupPref and +ben for the small change in browser_init. ...

8 years, 8 months ago (2012-04-25 03:26:36 UTC) #4

LGTM