Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 10212012: Update secureshell file (Closed)

Created:
8 years, 8 months ago by tturchetto
Modified:
8 years, 8 months ago
Reviewers:
craigdh, Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Update secureshell file Adding the latest secure shell BUG= TEST=This is for a test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133936

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/functional/chromeos_html_terminal.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
tturchetto
8 years, 8 months ago (2012-04-25 00:29:16 UTC) #1
craigdh
LGTM, assuming that the new crx file exists. Nit: In your CL description you should ...
8 years, 8 months ago (2012-04-25 00:55:11 UTC) #2
Nirnimesh
https://chromiumcodereview.appspot.com/10212012/diff/1/chrome/test/functional/chromeos_html_terminal.py File chrome/test/functional/chromeos_html_terminal.py (right): https://chromiumcodereview.appspot.com/10212012/diff/1/chrome/test/functional/chromeos_html_terminal.py#newcode28 chrome/test/functional/chromeos_html_terminal.py:28: 'SecureShell-dev-0.7.9.3.crx')) Please add the file first.
8 years, 8 months ago (2012-04-25 01:08:16 UTC) #3
tturchetto
On 2012/04/25 01:08:16, Nirnimesh wrote: > https://chromiumcodereview.appspot.com/10212012/diff/1/chrome/test/functional/chromeos_html_terminal.py > File chrome/test/functional/chromeos_html_terminal.py (right): > > https://chromereviews.googleplex.com/4377012/https://chromiumcodereview.appspot.com/10212012/diff/1/chrome/test/functional/chromeos_html_terminal.py#newcode28 > ...
8 years, 8 months ago (2012-04-25 01:51:58 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-25 01:52:37 UTC) #5
Nirnimesh
8 years, 8 months ago (2012-04-25 18:09:08 UTC) #6
LGTM. Please make sure you commit this _after_ the CL that uprevs
pyauto_private.

Powered by Google App Engine
This is Rietveld 408576698