Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10212008: Fix memory errors in sync unit tests (Closed)

Created:
8 years, 8 months ago by rlarocque
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Alpha Left Google, dpapad
Visibility:
Public.

Description

Fix memory errors in sync unit tests The commit r133754 introduced some errors. That change made the tests delete the session a bit more frequently, while some of the tests maintained more pointers to its internal structures. This change fixes all the affected tests and adds a member function to the test framework class to try to prevent this from happening in the future. BUG=122033, 123270 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133776

Patch Set 1 #

Patch Set 2 : Fix memory error in sync tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M sync/engine/syncer_unittest.cc View 7 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rlarocque
This should fix the build bot flakiness. This passes valgrind locally on my machine, while ...
8 years, 8 months ago (2012-04-24 21:49:17 UTC) #1
tim (not reviewing)
8 years, 8 months ago (2012-04-24 21:51:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698