Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10212002: Add the glibc upstream bug for the _dlerror_run leak to the suppression. (Closed)

Created:
8 years, 8 months ago by wtc
Modified:
8 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Add the glibc upstream bug for the _dlerror_run leak to the suppression. R=thestig@chromium.org BUG=51770 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133821

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add as a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
I should have filed the glibc upstream bug before I committed the previous CL https://chromiumcodereview.appspot.com/10206005. ...
8 years, 8 months ago (2012-04-24 18:18:55 UTC) #1
Lei Zhang
https://chromiumcodereview.appspot.com/10212002/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): https://chromiumcodereview.appspot.com/10212002/diff/1/tools/valgrind/memcheck/suppressions.txt#newcode441 tools/valgrind/memcheck/suppressions.txt:441: bug_51770 (Third Party) See http://sourceware.org/bugzilla/show_bug.cgi?id=14015 You can just put ...
8 years, 8 months ago (2012-04-24 19:22:25 UTC) #2
wtc
Please review patch set 2. Thanks.
8 years, 8 months ago (2012-04-25 00:10:27 UTC) #3
Lei Zhang
8 years, 8 months ago (2012-04-25 00:20:17 UTC) #4
LGTM

I would just commit this directly instead of using CQ.

Powered by Google App Engine
This is Rietveld 408576698