NaCl: Split the debug exception handler thread into a separate file

NaCl: Split the debug exception handler thread into a separate file

This is in preparation for changing nacl_process_host.cc to reuse this
code instead of having its own copy in DebugContext.  This needs to go
into chrome/common rather than chrome/nacl so that
nacl_process_host.cc can #include it under the checkdeps rules.

This changes the code to use PostTask() instead of PostDelayedTask().

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2618
TEST=run_inbrowser_exception_test in nacl_integration


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133851

[Mark Seaborn, 2012-04-24 19:37:08]

I'm not sure chrome/nacl is the best place for this, because I will need to
#include the new header from nacl_process_host.cc later, and that is currently
rejected by checkdeps:

ERROR in
/home/mseaborn/devel/newgit-chromium/src/chrome/browser/nacl_host/nacl_process_host.cc
Illegal include: "chrome/nacl/nacl_debug_exception_handler_win.h"
    Because of "-chrome" from chrome's include_rules.

Any ideas?

[Mark Seaborn, 2012-04-24 22:31:34]

On 2012/04/24 19:37:08, Mark Seaborn wrote:
> I'm not sure chrome/nacl is the best place for this, because I will need to
> #include the new header from nacl_process_host.cc later, and that is currently
> rejected by checkdeps:
> 
> ERROR in
>
/home/mseaborn/devel/newgit-chromium/src/chrome/browser/nacl_host/nacl_process_host.cc
> Illegal include: "chrome/nacl/nacl_debug_exception_handler_win.h"
>     Because of "-chrome" from chrome's include_rules.
> 
> Any ideas?

I've moved this to chrome/common as suggested by Brett.

Mark

[brettw, 2012-04-24 23:00:15]

I didn't actually read this, just noticed one thing.

https://chromiumcodereview.appspot.com/10211007/diff/7001/chrome/common/nacl_...
File chrome/common/nacl_debug_exception_handler_win.h (right):

https://chromiumcodereview.appspot.com/10211007/diff/7001/chrome/common/nacl_...
chrome/common/nacl_debug_exception_handler_win.h:14: base::Closure&
on_connected);
Pass this as const ref.

[Mark Seaborn, 2012-04-24 23:17:34]

http://codereview.chromium.org/10211007/diff/7001/chrome/common/nacl_debug_ex...
File chrome/common/nacl_debug_exception_handler_win.h (right):

http://codereview.chromium.org/10211007/diff/7001/chrome/common/nacl_debug_ex...
chrome/common/nacl_debug_exception_handler_win.h:14: base::Closure&
on_connected);
On 2012/04/24 23:00:15, brettw wrote:
> Pass this as const ref.

Done.

[sehr (please use chromium), 2012-04-24 23:58:16]

lgtm

[commit-bot: I haz the power, 2012-04-25 00:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10211007/7

[commit-bot: I haz the power, 2012-04-25 02:48:06]

Change committed as 133851