Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5663)

Unified Diff: chrome/common/extensions/extension_set_unittest.cc

Issue 102103005: Move c/c/e/extension_set to top-level extensions/ (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_set.cc ('k') | chrome/common/localized_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_set_unittest.cc
diff --git a/chrome/common/extensions/extension_set_unittest.cc b/chrome/common/extensions/extension_set_unittest.cc
deleted file mode 100644
index 2be19ca9892661f1ad605417f6e00f53391e482f..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/extension_set_unittest.cc
+++ /dev/null
@@ -1,140 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/files/file_path.h"
-#include "base/logging.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/common/extensions/extension_set.h"
-#include "extensions/common/extension.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using extensions::Extension;
-
-namespace {
-
-scoped_refptr<Extension> CreateTestExtension(const std::string& name,
- const std::string& launch_url,
- const std::string& extent) {
-#if defined(OS_WIN)
- base::FilePath path(FILE_PATH_LITERAL("c:\\"));
-#else
- base::FilePath path(FILE_PATH_LITERAL("/"));
-#endif
- path = path.AppendASCII(name);
-
- base::DictionaryValue manifest;
- manifest.SetString("name", name);
- manifest.SetString("version", "1");
-
- if (!launch_url.empty())
- manifest.SetString("app.launch.web_url", launch_url);
-
- if (!extent.empty()) {
- base::ListValue* urls = new base::ListValue();
- manifest.Set("app.urls", urls);
- urls->Append(new base::StringValue(extent));
- }
-
- std::string error;
- scoped_refptr<Extension> extension(
- Extension::Create(path, extensions::Manifest::INTERNAL, manifest,
- Extension::NO_FLAGS, &error));
- EXPECT_TRUE(extension.get()) << error;
- return extension;
-}
-
-} // namespace
-
-TEST(ExtensionSetTest, ExtensionSet) {
- scoped_refptr<Extension> ext1(CreateTestExtension(
- "a", "https://chrome.google.com/launch", "https://chrome.google.com/"));
-
- scoped_refptr<Extension> ext2(CreateTestExtension(
- "a", "http://code.google.com/p/chromium",
- "http://code.google.com/p/chromium/"));
-
- scoped_refptr<Extension> ext3(CreateTestExtension(
- "b", "http://dev.chromium.org/", "http://dev.chromium.org/"));
-
- scoped_refptr<Extension> ext4(
- CreateTestExtension("c", std::string(), std::string()));
-
- ASSERT_TRUE(ext1.get() && ext2.get() && ext3.get() && ext4.get());
-
- ExtensionSet extensions;
-
- // Add an extension.
- EXPECT_TRUE(extensions.Insert(ext1));
- EXPECT_EQ(1u, extensions.size());
- EXPECT_EQ(ext1, extensions.GetByID(ext1->id()));
-
- // Since extension2 has same ID, it should overwrite extension1.
- EXPECT_FALSE(extensions.Insert(ext2));
- EXPECT_EQ(1u, extensions.size());
- EXPECT_EQ(ext2, extensions.GetByID(ext1->id()));
-
- // Add the other extensions.
- EXPECT_TRUE(extensions.Insert(ext3));
- EXPECT_TRUE(extensions.Insert(ext4));
- EXPECT_EQ(3u, extensions.size());
-
- // Get extension by its chrome-extension:// URL
- EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL(
- ext2->GetResourceURL("test.html")));
- EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL(
- ext3->GetResourceURL("test.html")));
- EXPECT_EQ(ext4, extensions.GetExtensionOrAppByURL(
- ext4->GetResourceURL("test.html")));
-
- // Get extension by web extent.
- EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL(
- GURL("http://code.google.com/p/chromium/monkey")));
- EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL(
- GURL("http://dev.chromium.org/design-docs/")));
- EXPECT_FALSE(extensions.GetExtensionOrAppByURL(
- GURL("http://blog.chromium.org/")));
-
- // Test InSameExtent().
- EXPECT_TRUE(extensions.InSameExtent(
- GURL("http://code.google.com/p/chromium/monkey/"),
- GURL("http://code.google.com/p/chromium/")));
- EXPECT_FALSE(extensions.InSameExtent(
- GURL("http://code.google.com/p/chromium/"),
- GURL("https://code.google.com/p/chromium/")));
- EXPECT_FALSE(extensions.InSameExtent(
- GURL("http://code.google.com/p/chromium/"),
- GURL("http://dev.chromium.org/design-docs/")));
-
- // Both of these should be NULL, which mean true for InSameExtent.
- EXPECT_TRUE(extensions.InSameExtent(
- GURL("http://www.google.com/"),
- GURL("http://blog.chromium.org/")));
-
- // Remove one of the extensions.
- EXPECT_TRUE(extensions.Remove(ext2->id()));
- EXPECT_EQ(2u, extensions.size());
- EXPECT_FALSE(extensions.GetByID(ext2->id()));
-
- // Make a union of a set with 3 more extensions (only 2 are new).
- scoped_refptr<Extension> ext5(
- CreateTestExtension("d", std::string(), std::string()));
- scoped_refptr<Extension> ext6(
- CreateTestExtension("e", std::string(), std::string()));
- ASSERT_TRUE(ext5.get() && ext6.get());
-
- scoped_ptr<ExtensionSet> to_add(new ExtensionSet());
- // |ext3| is already in |extensions|, should not affect size.
- EXPECT_TRUE(to_add->Insert(ext3));
- EXPECT_TRUE(to_add->Insert(ext5));
- EXPECT_TRUE(to_add->Insert(ext6));
-
- ASSERT_TRUE(extensions.Contains(ext3->id()));
- ASSERT_TRUE(extensions.InsertAll(*to_add));
- EXPECT_EQ(4u, extensions.size());
-
- ASSERT_FALSE(extensions.InsertAll(*to_add)); // Re-adding same set no-ops.
- EXPECT_EQ(4u, extensions.size());
-}
« no previous file with comments | « chrome/common/extensions/extension_set.cc ('k') | chrome/common/localized_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698