Move c/c/e/extension_set to top-level extensions/

Move c/c/e/extension_set to top-level extensions/

Move extension_set.h/cc and extension_set_unittest to extensions/common/.
Remove unused includes.
Add includes where transitive includes were used.
Update DEPS.
No functional changes.

BUG=162530
TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test)
TBR=jam@chromium.org (c/b/automation)
TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy)
TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode)
TBR=satorux@chromium.org (c/b/chromeos)
TBR=yurys@chromium.org (c/b/devtools)
TBR=thestig@chromium.org (c/b/media_galleries)
TBR=stevenjb@chromium.org (c/b/notifications)
TBR=battre@chromium.org (c/b/profile_resetter)
TBR=dmazzoni@chromium.org (c/b/speech)
TBR=kinuko@chromium.org (c/b/sync_file_system)
TBR=pkotwicz@chromium.org (c/b/themes)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241131

[Devlin, 2013-12-04 00:49:45]

Working to reduce extensions/ DEPS on chrome/.  Please take a look when you get
a chance. =)

(Note, no functional changes anywhere - simple move.)

[benwells, 2013-12-04 03:48:07]

https://chromiumcodereview.appspot.com/102103005/diff/1/extensions/common/ext...
File extensions/common/extension_set.h (right):

https://chromiumcodereview.appspot.com/102103005/diff/1/extensions/common/ext...
extensions/common/extension_set.h:20: class ExtensionSet {
This might be painful, but can you move this into the extensions namespace?

Creating the extensions component is a great opportunity to get consistency with
namespaces.

[Devlin, 2013-12-10 21:25:31]

https://codereview.chromium.org/102103005/diff/1/extensions/common/extension_...
File extensions/common/extension_set.h (right):

https://codereview.chromium.org/102103005/diff/1/extensions/common/extension_...
extensions/common/extension_set.h:20: class ExtensionSet {
On 2013/12/04 03:48:08, benwells wrote:
> This might be painful, but can you move this into the extensions namespace?
> 
> Creating the extensions component is a great opportunity to get consistency
with
> namespaces.

Sorry for the delay, and thanks for catching that.  Done.

[benwells, 2013-12-11 00:03:42]

Looks like there are a bunch of includes that aren't used, and conversely some
.cc files that should include extension_set.h but aren't directly (i.e. they get
it through transitive includes). Can you clean this up?

sorry to be so picky...

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right):

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:33: #include
"extensions/common/extension_set.h"
nit: not used

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc
(right):

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc:18:
#include "extensions/common/extension_set.h"
nit: not used

[Devlin, 2013-12-11 20:09:11]

On 2013/12/11 00:03:42, benwells wrote:
> Looks like there are a bunch of includes that aren't used, and conversely some
> .cc files that should include extension_set.h but aren't directly (i.e. they
get
> it through transitive includes). Can you clean this up?
> 
> sorry to be so picky...
> 
>
https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
> File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
(right):
> 
>
https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:33:
#include
> "extensions/common/extension_set.h"
> nit: not used
> 
>
https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
> File
chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc
> (right):
> 
>
https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc:18:
> #include "extensions/common/extension_set.h"
> nit: not used

I think I got 'em all. There were surprisingly few unused includes (~4), but a
good chunk of transitives.

[Devlin, 2013-12-11 21:13:15]

(forgot that replying doesn't publish drafts)

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc
(right):

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc:18:
#include "extensions/common/extension_set.h"
On 2013/12/11 00:03:43, benwells wrote:
> nit: not used

This one actually is - on line 138.  If something's already in the extensions
namespace, no references will be updated.

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

https://codereview.chromium.org/102103005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_function_dispatcher.cc:244:
extension_info_map->extensions().GetByID(params.extension_id);
Lines like this make it tricky to easily tell if a file uses ExtensionSet, since
it never references it by name.

[benwells, 2013-12-13 01:38:11]

Nice change!

lgtm with one nit.

https://codereview.chromium.org/102103005/diff/40001/extensions/browser/DEPS
File extensions/browser/DEPS (left):

https://codereview.chromium.org/102103005/diff/40001/extensions/browser/DEPS#...
extensions/browser/DEPS:22: "+chrome/common/extensions/extension_set.h",
Nit: please remove from apps/DEPS as well (also extension.h is still there and
can be removed while you're at it).

[commit-bot: I haz the power, 2013-12-14 07:02:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/102103005/...

[commit-bot: I haz the power, 2013-12-14 07:19:56]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[jam, 2013-12-16 17:43:20]

c/b/automation lgtm

[commit-bot: I haz the power, 2013-12-16 18:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/102103005/...

[commit-bot: I haz the power, 2013-12-16 20:43:43]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 22:43:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/102103005/...

[commit-bot: I haz the power, 2013-12-17 00:40:20]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-17 00:55:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/102103005/...

[satorux1, 2013-12-17 02:18:37]

c/b/chromeos lgtm

[commit-bot: I haz the power, 2013-12-17 03:27:11]

Change committed as 241131