Per bug 121738, ignore old saved logins for http*://www.google.com.

chrome/browser/password_manager/password_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 34 matching lines @@
     : public RefcountedProfileKeyedService,
       public CancelableRequestProvider {
  public:
   typedef base::Callback<
       void(Handle, const std::vector<webkit::forms::PasswordForm*>&)>
       GetLoginsCallback;
 
   // PasswordForm vector elements are meant to be owned by the
   // PasswordStoreConsumer. However, if the request is canceled after the
   // allocation, then the request must take care of the deletion.
-  // TODO(scr) If we can convert vector<PasswordForm*> to
-  // ScopedVector<PasswordForm>, then we can move the following class to merely
-  // a typedef. At the moment, a subclass of CancelableRequest1 is required to
-  // provide a destructor, which cleans up after canceled requests by deleting
-  // vector elements.
   class GetLoginsRequest
       : public CancelableRequest1<GetLoginsCallback,
                                   std::vector<webkit::forms::PasswordForm*> > {
    public:
     explicit GetLoginsRequest(const GetLoginsCallback& callback);
 
+    void set_ignore_logins_cutoff(time_t cutoff) {
+      ignore_logins_cutoff_ = cutoff;
+    }
+
+    // Removes any logins in the result list that were saved before the cutoff.
+    void ApplyIgnoreLoginsCutoff();
+
    protected:
     virtual ~GetLoginsRequest();
 
    private:
+    // See GetLogins(). Logins older than this will be removed from the reply.
+    time_t ignore_logins_cutoff_;

[Ilya Sherman, 2012/05/02 22:10:17]

nit: Please use base::Time for this, unless there's a compelling reason not to?

[Mike Mammarella, 2012/05/07 00:14:36]

Done.

+
     DISALLOW_COPY_AND_ASSIGN(GetLoginsRequest);
   };
 
   // An interface used to notify clients (observers) of this object that data in
   // the password store has changed. Register the observer via
   // PasswordStore::SetObserver.
   class Observer {
    public:
     // Notifies the observer that password data changed in some way.
     virtual void OnLoginsChanged() = 0;
@@ skipping 91 matching lines @@
   virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request) = 0;
 
   // Finds all non-blacklist PasswordForms, and fills the vector.
   virtual bool FillAutofillableLogins(
       std::vector<webkit::forms::PasswordForm*>* forms) = 0;
   // Finds all blacklist PasswordForms, and fills the vector.
   virtual bool FillBlacklistLogins(
       std::vector<webkit::forms::PasswordForm*>* forms) = 0;
 
   // Dispatches the result to the PasswordStoreConsumer on the original caller's
-  // thread so the callback can be executed there.  This should be the UI
-  // thread.
+  // thread so the callback can be executed there. This should be the UI thread.
   virtual void ForwardLoginsResult(GetLoginsRequest* request);
 
+ private:
   // Schedule the given |func| to be run in the PasswordStore's own thread with
   // responses delivered to |consumer| on the current thread.
   template<typename BackendFunc>
   Handle Schedule(BackendFunc func, PasswordStoreConsumer* consumer);
 
   // Schedule the given |func| to be run in the PasswordStore's own thread with
-  // argument |a| and responses delivered to |consumer| on the current thread.
-  template<typename BackendFunc, typename ArgA>
+  // form |form| and responses delivered to |consumer| on the current thread.
+  // See GetLogins() for more information on |ignore_logins_cutoff|.
+  template<typename BackendFunc>
   Handle Schedule(BackendFunc func, PasswordStoreConsumer* consumer,
-                  const ArgA& a);
+                  const webkit::forms::PasswordForm& form,
+                  time_t ignore_logins_cutoff);
 
- private:
   // Wrapper method called on the destination thread (DB for non-mac) that
   // invokes |task| and then calls back into the source thread to notify
   // observers that the password store may have been modified via
   // NotifyLoginsChanged(). Note that there is no guarantee that the called
   // method will actually modify the password store data.
   void WrapModificationTask(base::Closure task);
 
   // Post a message to the UI thread to run NotifyLoginsChanged(). Called by
   // WrapModificationTask() above, and split out as a separate method so that
   // password sync can call it as well after synchronously updating the password
   // store.
   void PostNotifyLoginsChanged();
 
   // Called by WrapModificationTask() once the underlying data-modifying
   // operation has been performed. Notifies observers that password store data
   // may have been changed.
   void NotifyLoginsChanged();
 
   // The observers.
   ObserverList<Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStore);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_H_