Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10209027: Implement tracking and optimizations of packed arrays. (Closed)

Created:
8 years, 8 months ago by danno
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement tracking and optimizations of packed arrays. R=jkummerow@chromium.org TEST=test/mjsunit/packed-elements.js

Patch Set 1 #

Patch Set 2 : New upload #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1767 lines, -1092 lines) Patch
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
src/arm/full-codegen-arm.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/arm/ic-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 19 chunks +56 lines, -31 lines 0 comments Download
M src/checks.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/code-stubs.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M src/codegen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/contexts.h View 3 chunks +2 lines, -18 lines 0 comments Download
M src/elements.h View 3 chunks +9 lines, -3 lines 0 comments Download
M src/elements.cc View 23 chunks +269 lines, -114 lines 0 comments Download
A src/elements-kind.h View 1 chunk +200 lines, -0 lines 0 comments Download
M src/factory.h View 3 chunks +10 lines, -7 lines 0 comments Download
M src/factory.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 11 chunks +27 lines, -21 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 16 chunks +72 lines, -41 lines 0 comments Download
M src/hydrogen-instructions.h View 8 chunks +54 lines, -27 lines 0 comments Download
M src/hydrogen-instructions.cc View 5 chunks +19 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 7 chunks +31 lines, -17 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +49 lines, -36 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/ic.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/ic.cc View 4 chunks +49 lines, -16 lines 0 comments Download
src/jsregexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lithium.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/ic-mips.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +9 lines, -6 lines 0 comments Download
src/mips/lithium-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M src/objects.h View 11 chunks +30 lines, -61 lines 0 comments Download
M src/objects.cc View 44 chunks +297 lines, -178 lines 2 comments Download
src/objects-debug.cc View 5 chunks +17 lines, -6 lines 0 comments Download
M src/objects-inl.h View 18 chunks +117 lines, -114 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M src/parser.cc View 5 chunks +16 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime.cc View 37 chunks +137 lines, -86 lines 0 comments Download
M src/string-stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/array-construct-transition.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/array-literal-transitions.js View 2 chunks +2 lines, -164 lines 0 comments Download
M test/mjsunit/elements-kind.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/elements-kind-depends.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/elements-transition.js View 3 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/elements-transition-hoisting.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/packed-elements.js View 1 chunk +112 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1849.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1878.js View 1 chunk +2 lines, -2 lines 0 comments Download
test/mjsunit/regress/regress-crbug-122271.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-smi-only-concat.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/unbox-double-arrays.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 8 months ago (2012-04-27 13:35:06 UTC) #1
fschneider
8 years, 7 months ago (2012-05-09 11:30:33 UTC) #2 
dbc:

I have a CL that addes MUST_USE_RESULT to all functions in elements.h that
return a MaybeObject*.

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newc...
src/objects.cc:8508: accessor->CopyElements(this, new_elements,
new_elements_kind);
Missing check for failure? CopyElements has a MaybeObject* return type.

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newc...
src/objects.cc:9408: ValidateElements();
Maybe check result for failure before calling ValidateElements?

Powered by Google App Engine
This is Rietveld 408576698