Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 10209026: Make sure idle notifications perform a round of incremental GCs after context disposal. (Closed)

Created:
8 years, 8 months ago by ulan
Modified:
8 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Make sure idle notifications perform a round of incremental GCs after context disposal. BUG=v8:2107 Committed: https://code.google.com/p/v8/source/detail?r=11469

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -64 lines) Patch
M src/heap.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +78 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Please take a look. http://codereview.chromium.org/10209026/diff/1/src/heap.cc File src/heap.cc (left): http://codereview.chromium.org/10209026/diff/1/src/heap.cc#oldcode5063 src/heap.cc:5063: if (!WorthStartingGCWhenIdle()) { Experiments show ...
8 years, 8 months ago (2012-04-27 13:30:28 UTC) #1
Erik Corry
LGTM Is it possible to make some pure-V8 tests that test this?
8 years, 8 months ago (2012-04-27 15:00:35 UTC) #2
ulan
On 2012/04/27 15:00:35, Erik Corry wrote: > LGTM > > Is it possible to make ...
8 years, 8 months ago (2012-04-27 15:07:51 UTC) #3
ulan
8 years, 7 months ago (2012-04-30 14:11:31 UTC) #4
Added a regression test and improved the existing idle notification tests.

Powered by Google App Engine
This is Rietveld 408576698