Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10209008: Roll libjingle 132:133 (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -420 lines) Patch
M DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_xml_parser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_xml_parser_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/p2p/p2p_transport_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 2 4 chunks +9 lines, -13 lines 0 comments Download
M jingle/glue/channel_socket_adapter.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/utils.cc View 1 2 3 4 5 chunks +2 lines, -6 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M remoting/jingle_glue/xmpp_socket_adapter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_messages.h View 1 3 chunks +11 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 5 chunks +35 lines, -22 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 5 chunks +11 lines, -9 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/byteorder.h View 1 2 3 1 chunk +0 lines, -192 lines 0 comments Download
M third_party/libjingle/overrides/talk/base/scoped_ptr.h View 1 2 3 4 7 1 chunk +1 line, -17 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/win32.h View 1 2 3 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/win32.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
8 years, 8 months ago (2012-04-24 21:40:06 UTC) #1
Ronghua Wu (Left Chromium)
Can you also help remove below 3 files from the override folder? byteorder.h win32.cc win32.h ...
8 years, 8 months ago (2012-04-24 21:49:43 UTC) #2
Sergey Ulanov
removed overrides for win32.[cc|h] and byteorder.h http://codereview.chromium.org/10209008/diff/4002/remoting/protocol/jingle_messages.h File remoting/protocol/jingle_messages.h (right): http://codereview.chromium.org/10209008/diff/4002/remoting/protocol/jingle_messages.h#newcode75 remoting/protocol/jingle_messages.h:75: std::list<NamedCandidate> candidates; On ...
8 years, 8 months ago (2012-04-24 23:58:22 UTC) #3
Wez
lgtm
8 years, 8 months ago (2012-04-25 00:06:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10209008/3029
8 years, 8 months ago (2012-04-25 00:22:40 UTC) #5
Ronghua Wu (Left Chromium)
LGTM, thanks for removing those overrides files. http://codereview.chromium.org/10209008/diff/4002/remoting/protocol/jingle_messages.h File remoting/protocol/jingle_messages.h (right): http://codereview.chromium.org/10209008/diff/4002/remoting/protocol/jingle_messages.h#newcode75 remoting/protocol/jingle_messages.h:75: std::list<NamedCandidate> candidates; ...
8 years, 8 months ago (2012-04-25 00:29:09 UTC) #6
commit-bot: I haz the power
Try job failure for 10209008-3029 (retry) on android for steps "Compile, build". It's a second ...
8 years, 8 months ago (2012-04-25 00:39:21 UTC) #7
Sergey Ulanov
+jam for OWNERS approval for the /content and /chrome changes.
8 years, 8 months ago (2012-04-26 01:28:10 UTC) #8
ddorwin
8 years, 8 months ago (2012-04-26 01:54:03 UTC) #9 
lgtm

content/renderer/media/ LGTM

Powered by Google App Engine
This is Rietveld 408576698