Progress toward inlined type checks for classes with type arguments: factor out code, optimize typ…

runtime/vm/object.h

Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h	(revision 6912)
+++ runtime/vm/object.h	(working copy)
@@ -531,6 +531,9 @@
   void set_type_arguments_instance_field_offset(intptr_t value) const {
     raw_ptr()->type_arguments_instance_field_offset_ = value;
   }
+  static intptr_t type_arguments_instance_field_offset_offset() {
+    return OFFSET_OF(RawClass, type_arguments_instance_field_offset_);
+  }
 
   // The super type of this class, Object type if not explicitly specified.
   RawType* super_type() const { return raw_ptr()->super_type_; }
@@ -1042,6 +1045,7 @@
   virtual RawAbstractTypeArguments* arguments() const;
   virtual intptr_t token_index() const;
   virtual bool IsInstantiated() const { return true; }
+  virtual bool Equals(const AbstractType& other) const;

[regis, 2012/04/25 01:53:53]

Why do you need this?

[srdjan, 2012/04/25 16:38:01]

Canonicalization ... will try without.

 
   RawAbstractType* uninstantiated_type() const {
     return raw_ptr()->uninstantiated_type_;