Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 10207024: Temp patch to fix offical build due to 2x.pak reference (Closed)

Created:
8 years, 8 months ago by sail
Modified:
8 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Temp patch to fix offical build due to 2x.pak reference My Metro/HiDPI change (r133613) broke the official build. The problem was that I was referencing the new 2x pak files but they aren't created by default yet. mmoss is working on adding support for optional files. Until that is in I'm just removing the reference to the 2x pak files. This means that for now 2x pak files won't be archived but that's not a big deal since we don't build with HIDPI_ENABLED anyways. BUG=114311 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sail
8 years, 8 months ago (2012-04-24 22:56:37 UTC) #1
Michael Moss
8 years, 8 months ago (2012-04-24 23:00:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698