Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 10207021: Fix official build due to 2x.pak reference (Closed)

Created:
8 years, 8 months ago by sail
Modified:
8 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix official build due to 2x.pak reference My Metro/HiDPI change (r133613) broke the official build. The problem was that I was referencing the new 2x pak files but they aren't created by default yet. Fix was to mark the references as optional. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133939

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sail
8 years, 8 months ago (2012-04-24 19:44:30 UTC) #1
sail
8 years, 8 months ago (2012-04-24 19:49:48 UTC) #2
robertshield
LGTM, assuming the 'optional' thing works. I didn't see a reference to it in http://code.google.com/searchframe#OAMlx_jo-ck/tools/build/scripts/common/archive_utils.py&exact_package=chromium&q=archive_utils.py ...
8 years, 8 months ago (2012-04-24 19:51:31 UTC) #3
Michael Moss
On 2012/04/24 19:51:31, robertshield wrote: > LGTM, assuming the 'optional' thing works. Hmmm, you might ...
8 years, 8 months ago (2012-04-24 20:10:43 UTC) #4
sail
On 2012/04/24 20:10:43, Michael Moss wrote: > On 2012/04/24 19:51:31, robertshield wrote: > > LGTM, ...
8 years, 8 months ago (2012-04-24 20:12:08 UTC) #5
sail
mmoss is still working on adding support for the optional keyword. In the meantime I'm ...
8 years, 8 months ago (2012-04-24 23:01:11 UTC) #6
sail
8 years, 8 months ago (2012-04-25 18:16:49 UTC) #7
Michael Moss
8 years, 8 months ago (2012-04-25 18:20:32 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698