Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: webkit/appcache/appcache_storage_impl.cc

Issue 10207020: Workaround for a crashing appcache bug seen on the crash servers (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_storage_impl.cc
===================================================================
--- webkit/appcache/appcache_storage_impl.cc (revision 134562)
+++ webkit/appcache/appcache_storage_impl.cc (working copy)
@@ -424,6 +424,13 @@
(*group) = cache->get()->owning_group();
DCHECK(group->get());
DCHECK_EQ(group_record_.group_id, group->get()->group_id());
+
+ // TODO(michaeln): histogram is fishing for clues to crbug/95101
+ if (!cache->get()->GetEntry(group_record_.manifest_url)) {
+ AppCacheHistograms::AddMissingManifstDetectedAtCallsite(
+ AppCacheHistograms::CALLSITE_0);
+ }
+
storage_->NotifyStorageAccessed(group_record_.origin);
return;
}
@@ -440,12 +447,24 @@
if (group->get()) {
DCHECK(group_record_.group_id == group->get()->group_id());
group->get()->AddCache(cache->get());
+
+ // TODO(michaeln): histogram is fishing for clues to crbug/95101
+ if (!cache->get()->GetEntry(group_record_.manifest_url)) {
+ AppCacheHistograms::AddMissingManifstDetectedAtCallsite(
+ AppCacheHistograms::CALLSITE_1);
+ }
} else {
(*group) = new AppCacheGroup(
storage_->service_, group_record_.manifest_url,
group_record_.group_id);
group->get()->set_creation_time(group_record_.creation_time);
group->get()->AddCache(cache->get());
+
+ // TODO(michaeln): histogram is fishing for clues to crbug/95101
+ if (!cache->get()->GetEntry(group_record_.manifest_url)) {
+ AppCacheHistograms::AddMissingManifstDetectedAtCallsite(
+ AppCacheHistograms::CALLSITE_2);
+ }
}
DCHECK(group->get()->newest_complete_cache() == cache->get());
@@ -1423,6 +1442,12 @@
new StoreGroupAndCacheTask(this, group, newest_cache));
task->AddDelegate(GetOrCreateDelegateReference(delegate));
task->GetQuotaThenSchedule();
+
+ // TODO(michaeln): histogram is fishing for clues to crbug/95101
+ if (!newest_cache->GetEntry(group->manifest_url())) {
+ AppCacheHistograms::AddMissingManifstDetectedAtCallsite(
+ AppCacheHistograms::CALLSITE_3);
+ }
}
void AppCacheStorageImpl::FindResponseForMainRequest(

Powered by Google App Engine
This is Rietveld 408576698