Issue 10207020: Workaround for a crashing appcache bug seen on the crash servers

Issue 10207020: Workaround for a crashing appcache bug seen on the crash servers (Closed)

Created:
8 years, 8 months ago by michaeln

Modified:
8 years, 7 months ago

Reviewers:
jennb

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Workaround for a crashing appcache bug seen on the crash servers. Add an UMA stat to see how often this happens. Also cleanup a renmant of base::Bind transition. BUG=95101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135186

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -72 lines)			Patch
M	webkit/appcache/appcache_histograms.h	View	1 2 3 4 5 6 7	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_histograms.cc	View	1 2 3 4 5 6 7	2 chunks	+11 lines, -6 lines	0 comments	Download
M	webkit/appcache/appcache_service.h	View	1 2	4 chunks	+1 line, -4 lines	0 comments	Download
M	webkit/appcache/appcache_service.cc	View	1	6 chunks	+11 lines, -57 lines	0 comments	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 2 3 4 5 6 7	3 chunks	+25 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_update_job.cc	View	1 2 3	5 chunks	+13 lines, -3 lines	0 comments	Download
M	webkit/appcache/appcache_update_job_unittest.cc	View	1 2 3 4 5 6 7	6 chunks	+49 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennb

LGTM https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/appcache_histograms.h File webkit/appcache/appcache_histograms.h (right): https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/appcache_histograms.h#newcode43 webkit/appcache/appcache_histograms.h:43: static void AddMissingManifstDetectedAtCallsite( typo https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/appcache_update_job_unittest.cc File webkit/appcache/appcache_update_job_unittest.cc (right): ...

8 years, 7 months ago (2012-05-03 18:43:31 UTC) #2

michaeln

i've done some manual testing with a chrome build running locally by forcing things down ...

8 years, 7 months ago (2012-05-03 18:43:43 UTC) #3

michaeln

8 years, 7 months ago (2012-05-03 19:03:25 UTC) #4

https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/ap...
File webkit/appcache/appcache_histograms.h (right):

https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/ap...
webkit/appcache/appcache_histograms.h:43: static void
AddMissingManifstDetectedAtCallsite(
On 2012/05/03 18:43:31, jennb wrote:
> typo

Done.

https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/ap...
File webkit/appcache/appcache_update_job_unittest.cc (right):

https://chromiumcodereview.appspot.com/10207020/diff/17003/webkit/appcache/ap...
webkit/appcache/appcache_update_job_unittest.cc:993: void
UpgradeMissingManifestEntryDoesntCrash() {
On 2012/05/03 18:43:31, jennb wrote:
> nit: s/Doesnt/DoesNot

Done, renamed to Bug95101Test()

Expand Messages | Collapse Messages