Issue 10207014: Revert 133679 - Failing SelectFileDialogExtensionBrowserTest.SelectFileAndSave on chromiumos browse…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10207014: Revert 133679 - Failing SelectFileDialogExtensionBrowserTest.SelectFileAndSave on chromiumos browse… (Closed)

Created:
8 years, 8 months ago by flackr

Modified:
8 years, 8 months ago

Reviewers:
flackr

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 133679 - Failing SelectFileDialogExtensionBrowserTest.SelectFileAndSave on chromiumos browser_tests. This revert made things worse, investigating. Revert 133663 - 1. Fix JSDocs in directory_model.js. 2. Replace all getters and setters in directory_model.js with get*() and set*() methods. Review URL: https://chromiumcodereview.appspot.com/10206015 TBR=oleg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10201018 TBR=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133684

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+236 lines, -213 lines)			Patch
M	chrome/browser/resources/file_manager/js/directory_model.js	View	26 chunks	+190 lines, -167 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	34 chunks	+42 lines, -44 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_pyauto.js	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)