Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2844)

Unified Diff: dart/utils/compiler/compiler.gyp

Issue 10207010: Make dart2js work on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/utils/compiler/compiler.gyp
diff --git a/dart/utils/compiler/compiler.gyp b/dart/utils/compiler/compiler.gyp
index ecccdaf9cd57873e38b226a97f948a50993adff7..b65e42d593074c731cd75a583cdf7df71302e5d5 100644
--- a/dart/utils/compiler/compiler.gyp
+++ b/dart/utils/compiler/compiler.gyp
@@ -3,6 +3,9 @@
# BSD-style license that can be found in the LICENSE file.
{
+ 'variables': {
+ 'dart_dir': '../..',
+ },
'targets': [
{
'target_name': 'dart2js',
@@ -14,7 +17,7 @@
{
'action_name': 'build_dart2js',
'inputs': [
- '<(PRODUCT_DIR)/dart',
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
'build_helper.dart',
],
'outputs': [
@@ -22,12 +25,18 @@
'<(PRODUCT_DIR)/dart2js_developer',
],
'action': [
- '<(PRODUCT_DIR)/dart',
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
+ '--enable-checked-mode',
'build_helper.dart',
+ # Note: it would seem more straight-forward to pass in
+ # '<(PRODUCT_DIR)<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)'.
ngeoffray 2012/04/24 14:29:46 Should there be a '/' after PRODUCT_DIR?
ahe 2012/04/24 14:55:34 Done.
+ # Unfortunately, there is some strange interaction with
+ # GYP so it doesn't work.
ngeoffray 2012/04/24 14:29:46 GYP and paths on windows?
ahe 2012/04/24 14:55:34 Nope. The argument simply disappears, at least on
'<(PRODUCT_DIR)',
- 'dart',
+ '<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
'dart2js',
'dart2js_developer',
+ '<(dart_dir)',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698