Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: net/spdy/spdy_protocol_test.cc

Issue 10207001: Clean up a raft of SPDY files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no ssize_t :( Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_framer_test.cc ('K') | « net/spdy/spdy_framer_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol_test.cc
diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc
index 9dcd81d6ab9b9b5becfa719edfa180a9d9b3f179..d4d9b1fa2a1d121e3790fb28748f03aef00b7c3a 100644
--- a/net/spdy/spdy_protocol_test.cc
+++ b/net/spdy/spdy_protocol_test.cc
@@ -12,8 +12,8 @@
namespace {
enum SpdyProtocolTestTypes {
- SPDY2,
- SPDY3,
+ SPDY2 = 2,
+ SPDY3 = 3,
};
} // namespace
@@ -24,18 +24,15 @@ class SpdyProtocolTest
: public ::testing::TestWithParam<SpdyProtocolTestTypes> {
protected:
virtual void SetUp() {
- spdy_version_ = (GetParam() == SPDY2) ? 2 : 3;
+ spdy_version_ = GetParam();
}
- virtual void TearDown() {}
-
- bool IsSpdy2() { return spdy_version_ < 3; }
+ bool IsSpdy2() { return spdy_version_ == SPDY2; }
// Version of SPDY protocol to be used.
int spdy_version_;
};
-//-----------------------------------------------------------------------------
// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,
SpdyProtocolTest,
@@ -274,10 +271,9 @@ TEST_P(SpdyProtocolTest, HasHeaderBlock) {
}
}
-//-----------------------------------------------------------------------------
-// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
class SpdyProtocolDeathTest : public SpdyProtocolTest {};
+// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests,
SpdyProtocolDeathTest,
::testing::Values(SPDY2, SPDY3));
« net/spdy/spdy_framer_test.cc ('K') | « net/spdy/spdy_framer_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698