Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: runtime/bin/http.dart

Issue 10205012: Initial web socket server implementation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/http.dart
diff --git a/runtime/bin/http.dart b/runtime/bin/http.dart
index 41a0ac8bdc6a9380e99d717e97b5b89c713f7a9b..1cc5f1abe750cd68380906da6108ffdfc4a11cae 100644
--- a/runtime/bin/http.dart
+++ b/runtime/bin/http.dart
@@ -383,6 +383,14 @@ interface HttpResponse default _HttpResponse {
* having retrieved the output stream will throw an exception.
*/
OutputStream get outputStream();
+
+ /**
+ * When the HTTP protocol is upgraded use this method to get the
+ * underlying socket used for the communication. After calling
+ * [protocolUpgrade] the socket is fully detached from the HTTP
+ * server.
+ */
+ Socket protocolUpgrade();
Anders Johnsen 2012/04/24 12:20:47 Further comment that this can be done after the HT
Mads Ager (google) 2012/04/25 10:41:55 The name makes it sound like this is requesting a
Søren Gjesse 2012/04/25 13:57:14 Done.
Søren Gjesse 2012/04/25 13:57:14 Changed name to detachSocket.
}
@@ -405,6 +413,8 @@ interface HttpClient default _HttpClient {
*/
HttpClientConnection open(String method, String host, int port, String path);
+ //WebSocketConnection openWebSocket(protocols, String host, int port, String path);
Anders Johnsen 2012/04/24 12:20:47 Did you mean to include this?
Søren Gjesse 2012/04/25 13:57:14 No, removed.
+
/**
* Opens a HTTP connection. The returned [HttpClientConnection] is
* used to register callbacks for asynchronous events on the HTTP

Powered by Google App Engine
This is Rietveld 408576698