Issue 10205009: [OTS] TAG() macro for big endian

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10205009: [OTS] TAG() macro for big endian (Closed)

Created:
8 years, 8 months ago by bashi

Modified:
8 years, 7 months ago

Reviewers:
jfkthame, Yusuke Sato, agl

CC:
chromium-reviews, agl

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

[OTS] TAG() macro for big endian Add TAG() macro for big endian. BUG=chromium:124629 TEST=ran test_{un,}malicious_fonts.sh

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/ots.cc	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jfkthame

8 years, 7 months ago (2012-04-28 09:10:46 UTC) #4

https://chromiumcodereview.appspot.com/10205009/diff/1/src/ots.cc
File src/ots.cc (right):

https://chromiumcodereview.appspot.com/10205009/diff/1/src/ots.cc#newcode86
src/ots.cc:86: #if defined(__BIG_ENDIAN__) || defined(_BIG_ENDIAN)
Unfortunately, this doesn't work as intended on some systems - in the Android
NDK, and (at least some) OpenBSD systems, <endian.h> defines the symbol
_BIG_ENDIAN (with various levels of underscore-decoration) not to mean "this
system is big-endian" but as a magic constant to compare with _BYTE_ORDER. As a
result, the big-endian option here is chosen even on little-endian
architectures.

(See mozilla issue https://bugzilla.mozilla.org/show_bug.cgi?id=747816#c10.)

Expand Messages | Collapse Messages