Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5959)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 10204010: Handling default service in the web intents picker controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to head Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.h b/chrome/browser/ui/intents/web_intent_picker_controller.h
index d176456cd1fb5e565ba8c8447a3d981678aea9d2..1aec8ec6da149aec4986b266416ca4fa6473b844 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.h
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.h
@@ -105,6 +105,17 @@ class WebIntentPickerController : public content::NotificationObserver,
void OnWebIntentServicesAvailable(
const std::vector<webkit_glue::WebIntentServiceData>& services);
+ // Called when a default service is returned from the WebIntentsRegistry.
+ // (Still called with default_service.service_url empty if there are no
+ // defaults.)
+ void OnWebIntentDefaultsAvailable(
+ const DefaultWebIntentService& default_service);
+
+ // Coordination method which is delegated to by the registry calls to get
+ // services and defaults. Checks whether the picker should be shown or if
+ // default choices allow it to be skipped.
+ void RegistryCallsCompleted();
+
// Called when WebIntentServiceData is ready for checking extensions
// when dispatching explicit intents. Gets |services|
// from the WebIntentsRegistry to check for known urls/extensions and find
@@ -172,6 +183,9 @@ class WebIntentPickerController : public content::NotificationObserver,
// A count of the outstanding asynchronous calls.
int pending_async_count_;
+ // A count of outstanding WebIntentsRegistry calls.
+ int pending_registry_calls_count_;
+
// Is true if the picker is currently visible.
// This bool is not equivalent to picker != NULL in a unit test. In that
// case, a picker may be non-NULL before it is shown.

Powered by Google App Engine
This is Rietveld 408576698