Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4850)

Unified Diff: chrome_frame/test/ui_test.cc

Issue 10203011: Flaking out some tests that use simulate_input::SendCharA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/ui_test.cc
diff --git a/chrome_frame/test/ui_test.cc b/chrome_frame/test/ui_test.cc
index 4398178075f6fed370853dc186e77d008bf64ae6..b8c13c4e418537bf197a1b1c9e3bfa3a0e46c526 100644
--- a/chrome_frame/test/ui_test.cc
+++ b/chrome_frame/test/ui_test.cc
@@ -113,7 +113,8 @@ TEST_P(FullTabUITest, DISABLED_KeyboardBackForward) {
}
// Tests new window behavior with ctrl+N.
-TEST_P(FullTabUITest, CtrlN) {
+// Flaky due to DelaySendChar; see http://crbug.com/124244.
+TEST_P(FullTabUITest, FLAKY_CtrlN) {
if (IsWorkstationLocked()) {
LOG(ERROR) << "This test cannot be run in a locked workstation.";
return;
@@ -154,7 +155,8 @@ TEST_P(FullTabUITest, CtrlN) {
}
// Test that Ctrl+F opens the Find dialog.
-TEST_P(FullTabUITest, CtrlF) {
+// Flaky due to DelaySendChar; see http://crbug.com/124244.
+TEST_P(FullTabUITest, FLAKY_CtrlF) {
if (IsWorkstationLocked()) {
LOG(ERROR) << "This test cannot be run in a locked workstation.";
return;
@@ -187,7 +189,8 @@ TEST_P(FullTabUITest, CtrlF) {
}
// Test that ctrl+r does cause a refresh.
-TEST_P(FullTabUITest, CtrlR) {
+// Flaky due to DelaySendChar; see http://crbug.com/124244.
+TEST_P(FullTabUITest, FLAKY_CtrlR) {
if (IsWorkstationLocked()) {
LOG(ERROR) << "This test cannot be run in a locked workstation.";
return;
@@ -215,7 +218,8 @@ TEST_P(FullTabUITest, CtrlR) {
}
// Test window close with ctrl+w.
-TEST_P(FullTabUITest, CtrlW) {
+// Flaky due to DelaySendChar; see http://crbug.com/124244.
+TEST_P(FullTabUITest, FLAKY_CtrlW) {
if (IsWorkstationLocked()) {
LOG(ERROR) << "This test cannot be run in a locked workstation.";
return;
@@ -235,7 +239,8 @@ TEST_P(FullTabUITest, CtrlW) {
}
// Test address bar navigation with Alt+d and URL.
-TEST_P(FullTabUITest, AltD) {
+// Flaky due to TypeUrlInAddressBar; see http://crbug.com/124244.
+TEST_P(FullTabUITest, FLAKY_AltD) {
if (IsWorkstationLocked()) {
LOG(ERROR) << "This test cannot be run in a locked workstation.";
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698