Issue 10203010: Improve --trace-gvn debug output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10203010: Improve --trace-gvn debug output (Closed)

Created:
8 years, 8 months ago by danno

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve --trace-gvn debug output R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11433

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -14 lines)			Patch
	M	src/hydrogen.cc	View	1	4 chunks	+106 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 8 months ago (2012-04-24 15:04:08 UTC) #2

LGTM (with a few nits).

https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:1563: for (int bit = 0; bit < 31; ++bit) {
Better use "kAfterLastFlag" instead of "31" here.

https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:1572: bool positive_changes = set_changes < 8;
It would also be nice if "8" would somehow be based on the number of GVN flags.
Currently "set_changes <= kAfterLastFlag / 4" would probably do the trick. But I
don't know if that is less hacky.

https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:1580: for (int bit = 0; bit < 31; ++bit) {
Likewise.

https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:1609: for (int bit = 0; bit < 31; ++bit) {
Likewise.

Expand Messages | Collapse Messages