fix downloads to use loadTimeData

fix downloads to use loadTimeData

BUG=122753
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134582

[Randy Smith (Not in Mondays), 2012-04-26 22:02:28]

I'd like Ben to be on top of changes to the downloads page; Ben, could you take
a look at this?

[benjhayden, 2012-04-27 13:43:40]

lgtm

[Dan Beam, 2012-04-27 18:32:39]

this should obviously wait for your CL to land which actually adds GetStringF,
;)

http://codereview.chromium.org/10202025/diff/1001/chrome/browser/ui/webui/dow...
File chrome/browser/ui/webui/downloads_ui.cc (right):

http://codereview.chromium.org/10202025/diff/1001/chrome/browser/ui/webui/dow...
chrome/browser/ui/webui/downloads_ui.cc:99: source->set_use_json_js_format_v2();
his needs to be updated to a scoped thinger, now, right?

[Evan Stade, 2012-04-28 00:48:03]

http://codereview.chromium.org/10202025/diff/1001/chrome/browser/ui/webui/dow...
File chrome/browser/ui/webui/downloads_ui.cc (right):

http://codereview.chromium.org/10202025/diff/1001/chrome/browser/ui/webui/dow...
chrome/browser/ui/webui/downloads_ui.cc:99: source->set_use_json_js_format_v2();
On 2012/04/27 18:32:39, Dan Beam wrote:
> his needs to be updated to a scoped thinger, now, right?

no

[Dan Beam, 2012-04-30 18:24:33]

lgtm

[commit-bot: I haz the power, 2012-04-30 18:38:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10202025/1001

[commit-bot: I haz the power, 2012-04-30 18:38:48]

Presubmit check for 10202025-1001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/downloads/downloads.js:
  line 10: E0210: Missing docs for parameter: "node"
function showInline(node, isShow) {
                                ^^
  line 10: E0210: Missing docs for parameter: "isShow"
function showInline(node, isShow) {
                                ^^
  line 22: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 33: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 47: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 204: E0212: Parameter mismatch: got "downloads", expected "array"
Downloads.prototype.isUpdateNeeded = function(downloads) {
                                                       ^^
  line 211: E0002: Missing space before "("
    if(this.downloads_[i].url_ != downloads[i].url)
      ^
  line 362: E0010: Missing semicolon at end of line
}
^
  line 548: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 557: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 566: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 575: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 585: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 594: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 603: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 612: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 681: E0210: Missing docs for parameter: "results"
function downloadsList(results) {
                              ^^
  line 695: E0210: Missing docs for parameter: "results"
function downloadUpdated(results) {
                                ^^

Presubmit checks took 1.5s to calculate.