Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 10202007: Re-enable optimization for hot functions that have optimization disabled due to many deopts. (Closed)

Created:
8 years, 8 months ago by ulan
Modified:
8 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Re-enable optimization for hot functions that have optimization disabled due to many deopts. Use exponential backoff in order to avoid getting into optimization-deoptimization cycle. BUG=v8:2040, 121196 Committed: https://code.google.com/p/v8/source/detail?r=11425

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Change to >= 4 #

Patch Set 3 : fix 64-bit compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -21 lines) Patch
M src/heap.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/objects.h View 1 2 5 chunks +16 lines, -9 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 5 chunks +25 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 5 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Please take a look.
8 years, 8 months ago (2012-04-24 09:42:13 UTC) #1
fschneider
On 2012/04/24 09:42:13, ulan wrote: > Please take a look. dbc: Is this also related ...
8 years, 8 months ago (2012-04-24 10:09:56 UTC) #2
Jakob Kummerow
LGTM http://codereview.chromium.org/10202007/diff/4001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/10202007/diff/4001/src/objects-inl.h#newcode3708 src/objects-inl.h:3708: if (tries > 4 && (((tries - 1) ...
8 years, 8 months ago (2012-04-24 10:38:22 UTC) #3
ulan
8 years, 8 months ago (2012-04-24 12:36:07 UTC) #4
> dbc: Is this also related to this issue? 
> http://code.google.com/p/v8/issues/detail?id=1902
Yes, it is related. However it doesn't fix that issue completely. The first run
now takes consistently about 4000ms. But subsequent runs alternate between
4000ms and 7000ms, which doesn't happen with the old profiler.

http://codereview.chromium.org/10202007/diff/4001/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/10202007/diff/4001/src/objects-inl.h#newcode3708
src/objects-inl.h:3708: if (tries > 4 && (((tries - 1) & tries) == 0)) {
On 2012/04/24 10:38:22, Jakob wrote:
> nit: did you mean ">= 4"?
Yes, that's what I meant. :)
Performance on our benchmarks is similar, but in mandreel test the ">=" version
runs slightly faster.

Powered by Google App Engine
This is Rietveld 408576698