Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4614)

Unified Diff: chrome/browser/sessions/session_service.h

Issue 10202005: Convert the session restore ui_tests to browser_tests. I renabled the disabled tests; hopefully the… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: renable the mac test Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/browser/sessions/session_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_service.h
===================================================================
--- chrome/browser/sessions/session_service.h (revision 133679)
+++ chrome/browser/sessions/session_service.h (working copy)
@@ -53,7 +53,8 @@
// of the browser.
class SessionService : public BaseSessionService,
public content::NotificationObserver {
- friend class SessionServiceTestHelper;
+ friend class SessionRestoreTest;
+ friend class SessionServiceTestHelper;
public:
// Used to distinguish an application window from a normal one.
enum AppType {
@@ -387,6 +388,7 @@
// windows or similar. In this case, we record the close as pending.
return !has_open_trackable_browsers_ &&
(!browser_defaults::kBrowserAliveWithNoWindows ||
+ force_browser_not_alive_with_no_windows_ ||
BrowserList::size() > 1);
}
@@ -462,6 +464,10 @@
const base::TimeDelta save_delay_in_mins_;
const base::TimeDelta save_delay_in_hrs_;
+ // For browser_tests, since we want to simulate the browser shutting down
+ // without quitting.
+ bool force_browser_not_alive_with_no_windows_;
+
DISALLOW_COPY_AND_ASSIGN(SessionService);
};
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/browser/sessions/session_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698