Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10202005: Convert the session restore ui_tests to browser_tests. I renabled the disabled tests; hopefully the… (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, erikwright (departed), joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Convert the session restore ui_tests to browser_tests. I renabled the disabled tests; hopefully they're now less flaky. I found a simple way of launching a browser_test binary as a regular chrome binary which is needed for the app test case. This means I can undo r133560 which I've done here. BUG=121574, 29110, 52022 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133852

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : fix mac + cros #

Patch Set 5 : fix cros and disable the one test on mac #

Patch Set 6 : renable the mac test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -669 lines) Patch
M base/test/test_suite.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/test/test_suite.cc View 3 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 5 chunks +17 lines, -42 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 3 4 5 5 chunks +363 lines, -29 lines 0 comments Download
D chrome/browser/sessions/session_restore_uitest.cc View 1 chunk +0 lines, -491 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.h View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_suite.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.h View 1 chunk +1 line, -17 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M content/test/test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 8 months ago (2012-04-24 14:59:29 UTC) #1
sky
8 years, 8 months ago (2012-04-24 16:00:06 UTC) #2 
LGTM

http://codereview.chromium.org/10202005/diff/3011/chrome/test/base/chrome_tes...
File chrome/test/base/chrome_test_suite.h (right):

http://codereview.chromium.org/10202005/diff/3011/chrome/test/base/chrome_tes...
chrome/test/base/chrome_test_suite.h:29: static const char kLaunchAsBrowser[];
nit: static consts before constructor.

Powered by Google App Engine
This is Rietveld 408576698