Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 10202004: Merge 114599 - [chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initializa… (Closed)

Created:
8 years, 8 months ago by jamesr
Modified:
8 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 114599 - [chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available https://bugs.webkit.org/show_bug.cgi?id=84301 Reviewed by Adrienne Walker. Source/WebCore: If our composited surface isn't ready yet, then the compositor may initialize in a state where the first makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up. Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests. * platform/graphics/chromium/cc/CCScheduler.cpp: (WebCore::CCScheduler::setCanBeginFrame): (WebCore): * platform/graphics/chromium/cc/CCScheduler.h: (CCScheduler): * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine): (WebCore::CCSchedulerStateMachine::nextAction): * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: (WebCore::CCSchedulerStateMachine::setCanBeginFrame): (CCSchedulerStateMachine): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::initializeImplOnImplThread): Source/WebKit/chromium: Update unit tests for new canBeginFrame bit. * tests/CCSchedulerStateMachineTest.cpp: (WebCore::TEST): (WebCore): * tests/CCSchedulerTest.cpp: (WebKitTests::TEST): TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3327 lines, -1 line) Patch
M Source/WebCore/ChangeLog View 1 chunk +947 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCScheduler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 2 chunks +2310 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp View 20 chunks +48 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/CCSchedulerTest.cpp View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 8 months ago (2012-04-24 01:25:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698