Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10201008: Merge 114475 - [chromium] Ensure RateLimiter waits for Swapbuffers completion (Closed)

Created:
8 years, 8 months ago by jamesr
Modified:
8 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 114475 - [chromium] Ensure RateLimiter waits for Swapbuffers completion https://bugs.webkit.org/show_bug.cgi?id=83649 Patch by John Bauman <jbauman@chromium.org>; on 2012-04-17 Reviewed by James Robinson. We were waiting only on the canvas context, which with the new GPU scheduling was causing the RateLimiter not to ratelimit enough. We need to insert no-op commands in the compositor context, so that we'll wait for the canvas context and SwapBuffers as well. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::doNoOp): (WebCore): * platform/graphics/chromium/LayerRendererChromium.h: (LayerRendererChromium): * platform/graphics/chromium/RateLimiter.cpp: (WebCore::RateLimiter::create): (WebCore::RateLimiter::RateLimiter): (WebCore::RateLimiter::rateLimitContext): * platform/graphics/chromium/RateLimiter.h: (RateLimiterClient): (WebCore): (RateLimiter): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::startRateLimiter): (WebCore::CCLayerTreeHost::rateLimit): (WebCore): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCProxy.h: (CCProxy): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::forceNoOpCommand): (WebCore): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (CCSingleThreadProxy): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::forceNoOpCommand): (WebCore): (WebCore::CCThreadProxy::forceNoOpCommandOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.h: (CCThreadProxy): TBR=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12454 lines, -7 lines) Patch
M Source/WebCore/ChangeLog View 3 chunks +12391 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/RateLimiter.h View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/RateLimiter.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCProxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
8 years, 8 months ago (2012-04-23 23:52:06 UTC) #1
jbauman
8 years, 8 months ago (2012-04-24 00:12:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698