Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 10200002: Sync UI: Use camelCase for variables sent to JS. (Closed)

Created:
8 years, 8 months ago by James Hawkins
Modified:
8 years, 8 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Sync UI: Use camelCase for variables sent to JS. BUG=119646 TEST=none R=dbeam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133734

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -95 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 12 chunks +51 lines, -45 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 7 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 9 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
8 years, 8 months ago (2012-04-23 21:29:04 UTC) #1
Dan Beam
lgtm w/nits + green try runs https://chromiumcodereview.appspot.com/10200002/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): https://chromiumcodereview.appspot.com/10200002/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode288 chrome/browser/resources/sync_setup_overlay.js:288: @param {Object} args ...
8 years, 8 months ago (2012-04-23 21:32:56 UTC) #2
James Hawkins
https://chromiumcodereview.appspot.com/10200002/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): https://chromiumcodereview.appspot.com/10200002/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode288 chrome/browser/resources/sync_setup_overlay.js:288: On 2012/04/23 21:32:56, Dan Beam wrote: > @param {Object} ...
8 years, 8 months ago (2012-04-24 16:53:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10200002/4001
8 years, 8 months ago (2012-04-24 17:02:48 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 18:44:01 UTC) #5
Change committed as 133734

Powered by Google App Engine
This is Rietveld 408576698