Make String::Empty inlineable.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4612 matching lines @@
 
 void* External::Value() const {
   if (IsDeadCheck(i::Isolate::Current(), "v8::External::Value()")) return 0;
   i::Handle<i::Object> obj = Utils::OpenHandle(this);
   return ExternalValueImpl(obj);
 }
 
 
 Local<String> v8::String::Empty() {
   i::Isolate* isolate = i::Isolate::Current();
-  EnsureInitializedForIsolate(isolate, "v8::String::Empty()");
+  if (!EnsureInitializedForIsolate(isolate, "v8::String::Empty()")) {

[Sven Panne, 2012/04/25 06:56:22]

Just out of curiosity: Why do we need this change? Or asked another way: Why do
we *not* need it in tons of other places? Or should we test the result of
EnusreInitializedForIsolate everywhere? api.cc is extremely inconsistent...

[Michael Starzinger, 2012/04/25 08:18:31]

Yes, IMHO we need this change in tons of other places. Because
EnsureInitializedForIsolate() can return even though the Isolate is not
initialized or is already dead, in cases where the embedder installed a fatal
error handler with SetFatalErrorHandler() that doesn't terminate the
application.

This just wasn't tested for String::Empty() before. I'll try to fix this
incrementally with my changes. We could also fix this for all functions in one
sweep, I you think that's worth the trouble.

+    return v8::Local<String>();
+  }
   LOG_API(isolate, "String::Empty()");
   return Utils::ToLocal(isolate->factory()->empty_symbol());
 }
 
 
 Local<String> v8::String::New(const char* data, int length) {
   i::Isolate* isolate = i::Isolate::Current();
   EnsureInitializedForIsolate(isolate, "v8::String::New()");
   LOG_API(isolate, "String::New(char)");
   if (length == 0) return Empty();
@@ skipping 1765 matching lines @@
 
 
 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
   HandleScopeImplementer* scope_implementer =
       reinterpret_cast<HandleScopeImplementer*>(storage);
   scope_implementer->IterateThis(v);
   return storage + ArchiveSpacePerThread();
 }
 
 } }  // namespace v8::internal