Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/skia.gyp

Issue 10198027: enable android x86 build (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: patch updated to address review issues Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | third_party/yasm/source/config/android/Makefile » ('j') | third_party/yasm/source/config/android/Makefile » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia.gyp
diff --git a/skia/skia.gyp b/skia/skia.gyp
index 835d20e3b6bc56bf4f1caec97406a3628342d7b1..f4eaf3de099d669d510403f3dfb82879ec96fd92 100644
--- a/skia/skia.gyp
+++ b/skia/skia.gyp
@@ -1098,8 +1098,13 @@
'../third_party/skia/src/opts/SkBlitRow_opts_SSE2.cpp',
'../third_party/skia/src/opts/SkUtils_opts_SSE2.cpp',
],
- 'dependencies': [
- 'skia_opts_ssse3',
+ 'conditions': [
+ # Remove SSSE3 opt for x86 Android.
Nico 2012/04/27 05:29:22 Change the comment to say why, not what (e.g. "And
Wei James 2012/04/27 08:59:05 fixed. thanks
+ [ 'OS != "android"', {
+ 'dependencies': [
+ 'skia_opts_ssse3',
+ ],
+ }],
],
},
{ # arm
« build/common.gypi ('K') | « build/common.gypi ('k') | third_party/yasm/source/config/android/Makefile » ('j') | third_party/yasm/source/config/android/Makefile » ('J')

Powered by Google App Engine
This is Rietveld 408576698