enable android x86 build

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 784 matching lines @@
           ['(branding=="Chrome" and buildtype=="Official")', {
             'linux_dump_symbols%': 1,
           }],
         ],
       }],  # os_posix==1 and OS!="mac" and OS!="android"
       ['OS=="android"', {
         # Location of Android NDK.
         'variables': {
           'variables': {
             'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
-            'target_arch%': 'arm',  # target_arch in android terms.
+            'conditions': [
+              ['target_arch == "ia32"', {

[Paweł Hajdan Jr., 2012/04/27 06:56:19]

Wait, target_arch is our (Chromium) thing, so it should be possible to adjust it
to the Android naming scheme so that we don't need those confusing conversions.

I don't expect you to do it right now, but please file a bug and put a TODO here
linking to the bug.

It's important!

[Wei James, 2012/04/27 08:59:05]

fixed with target_arch. thanks 

+                'platform_arch%': 'x86',

[Nico, 2012/04/27 05:29:22]

Remove trailing %

[Wei James, 2012/04/27 08:59:05]

changed to target_arch and removed %. thanks 

+              }, {

[Paweł Hajdan Jr., 2012/04/27 06:56:19]

I don't think the assumption that non-ia32 is an arm will always hold. This
seems fragile.

[Wei James, 2012/04/27 08:59:05]

use target_arch and only change "ia32" to "x86" when target_arch == "ia32".
thanks

+                'platform_arch%': 'arm',

[Nico, 2012/04/27 05:29:22]

Remove trailing %

[Wei James, 2012/04/27 08:59:05]

fixed. thanks 

+              }],
+            ],
 
             # Switch between different build types, currently only '0' is
             # supported.
             'android_build_type%': 0,
           },
           'android_ndk_root%': '<(android_ndk_root)',
-          'android_ndk_sysroot': '<(android_ndk_root)/platforms/android-9/arch-<(target_arch)',
+          'android_ndk_sysroot': '<(android_ndk_root)/platforms/android-9/arch-<(platform_arch)',
           'android_build_type%': '<(android_build_type)',
         },
         'android_ndk_root%': '<(android_ndk_root)',
         'android_ndk_sysroot': '<(android_ndk_sysroot)',
         'android_ndk_include': '<(android_ndk_sysroot)/usr/include',
         'android_ndk_lib': '<(android_ndk_sysroot)/usr/lib',
 
         # Uses Android's crash report system
         'linux_breakpad%': 0,
 
@@ skipping 127 matching lines @@
             'secure_atl%': 1,
           }],
         ],
         'nacl_win64_defines': [
           # This flag is used to minimize dependencies when building
           # Native Client loader for 64-bit Windows.
           'NACL_WIN64',
         ],
       }],
 
-      ['os_posix==1 and chromeos==0 and target_arch!="arm"', {
+      ['os_posix==1 and chromeos==0 and OS!="android"', {
         'use_cups%': 1,
       }, {
         'use_cups%': 0,
       }],
 
       # Set the relative path from this file to the GYP file of the JPEG
       # library used by Chromium.
       ['use_libjpeg_turbo==1', {
         'libjpeg_gyp_path': '../third_party/libjpeg_turbo/libjpeg.gyp',
       }, {
@@ skipping 1387 matching lines @@
               'HAVE_OFF64_T',
               'HAVE_SYS_UIO_H',
               'ANDROID_BINSIZE_HACK', # Enable temporary hacks to reduce binsize.
             ],
             'ldflags!': [
               '-pthread',  # Not supported by Android toolchain.
             ],
             'ldflags': [
               '-nostdlib',
               '-Wl,--no-undefined',
-              '-Wl,--icf=safe',  # Enable identical code folding to reduce size
               # Don't export symbols from statically linked libraries.
               '-Wl,--exclude-libs=ALL',
             ],
+            'conditions': [
+              ['target_arch == "arm"', {
+                'ldflags': [
+                  # Enable identical code folding to reduce size.
+                  '-Wl, --icf=safe', 

[Paweł Hajdan Jr., 2012/04/27 06:56:19]

nit: Are you sure there should be a space between the comma and "--"? Even if
that works, no space seems safer.

[Wei James, 2012/04/27 08:59:05]

fixed. thanks 

+                ],
+              }],
+            ],
             'libraries': [
               '-l<(android_stlport_library)',
               # Manually link the libgcc.a that the cross compiler uses.
               '<!(${ANDROID_TOOLCHAIN}/*-gcc -print-libgcc-file-name)',
               '-lc',
               '-ldl',
               '-lstdc++',
               '-lm',
             ],
             'conditions': [
@@ skipping 648 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }