chrome/browser/sync/glue/session_model_associator.cc - Issue 10198015: Sync: Fix crash in favicon sync code (using string after free).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/session_model_associator.cc

Issue 10198015: Sync: Fix crash in favicon sync code (using string after free). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/session_model_associator.cc

diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc

index ed3b66451c184d98a19d498c83057faedf7693ad..4196246d14b515bfc177b1426c47cf88840de2df 100644

--- a/chrome/browser/sync/glue/session_model_associator.cc

+++ b/chrome/browser/sync/glue/session_model_associator.cc

@@ -951,7 +951,7 @@ void SessionModelAssociator::DecrementAndCleanFaviconForURL(

std::map<std::string, std::string>::const_iterator iter =

synced_favicon_pages_.find(page_url);

if (iter != synced_favicon_pages_.end()) {

- const std::string& favicon_url = iter->second;

+ const std::string favicon_url = iter->second;

DCHECK_GT(synced_favicons_[favicon_url]->usage_count, 0);

--(synced_favicons_[favicon_url]->usage_count);

if (synced_favicons_[favicon_url]->usage_count <= 0) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »