Issue 10198015: Sync: Fix crash in favicon sync code (using string after free).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10198015: Sync: Fix crash in favicon sync code (using string after free). (Closed)

Created:
8 years, 8 months ago by Patrick Dubroy

Modified:
8 years, 8 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sync: Fix crash in favicon sync code (using string after free). BUG=124802 TEST=Start up two browsers with the --sync-tab-favicons option. Sign in in both browsers, open some tabs and do some browsing. Ensure that no crash occurs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133895

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/sync/glue/session_model_associator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

woops, LGTM

Expand Messages | Collapse Messages