Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: src/profile-generator.h

Issue 10198011: Refactoring of heap profiler: split ExtractReferences into several functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | src/profile-generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 3b748e234f1823644325c6c2ef6ec069341ada66..201f2c3a226f6b7ff872474b28c0e8eb28f1beca 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -975,6 +975,17 @@ class V8HeapExplorer : public HeapEntriesAllocator {
int children_count,
int retainers_count);
const char* GetSystemEntryName(HeapObject* object);
+
+ void ExtractJSGlobalProxy(JSGlobalProxy* proxy);
+ void ExtractJSObject(HeapEntry* entry, JSObject* js_obj);
+ void ExtractString(HeapEntry* entry, String* obj);
+ void ExtractContext(HeapEntry* entry, Context* context);
+ void ExtractMap(HeapEntry* entry, Map* map);
+ void ExtractSharedFunctionInfo(HeapEntry* entry, SharedFunctionInfo* shared);
+ void ExtractScript(HeapEntry* entry, Script* script);
+ void ExtractCodeCache(HeapEntry* entry, CodeCache* code_cache);
+ void ExtractCode(HeapEntry* entry, Code* code);
+
mnaganov (inactive) 2012/04/24 12:25:45 nit: Why blank line?
alexeif 2012/04/24 12:33:28 Done.
void ExtractReferences(HeapObject* obj);
void ExtractClosureReferences(JSObject* js_obj, HeapEntry* entry);
void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry);
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | src/profile-generator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698