Refactoring of heap profiler: split ExtractReferences into several functions.

src/profile-generator.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 957 matching lines @@
 
  private:
   HeapEntry* AddEntry(
       HeapObject* object, int children_count, int retainers_count);
   HeapEntry* AddEntry(HeapObject* object,
                       HeapEntry::Type type,
                       const char* name,
                       int children_count,
                       int retainers_count);
   const char* GetSystemEntryName(HeapObject* object);
+
   void ExtractReferences(HeapObject* obj);
+  void ExtractJSGlobalProxy(JSGlobalProxy* proxy);
+  void ExtractJSObject(HeapEntry* entry, JSObject* js_obj);
+  void ExtractString(HeapEntry* entry, String* obj);
+  void ExtractContext(HeapEntry* entry, Context* context);
+  void ExtractMap(HeapEntry* entry, Map* map);
+  void ExtractSharedFunctionInfo(HeapEntry* entry, SharedFunctionInfo* shared);
+  void ExtractScript(HeapEntry* entry, Script* script);
+  void ExtractCodeCache(HeapEntry* entry, CodeCache* code_cache);
+  void ExtractCode(HeapEntry* entry, Code* code);

[yurys, 2012/04/25 06:30:44]

You should be more consistent in using/not using *References suffix: currently
it is ExtractCode but ExtractClosureReferences.

   void ExtractClosureReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractElementReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractInternalReferences(JSObject* js_obj, HeapEntry* entry);
   bool IsEssentialObject(Object* object);
   void SetClosureReference(HeapObject* parent_obj,
                            HeapEntry* parent,
                            String* reference_name,
                            Object* child);
   void SetNativeBindReference(HeapObject* parent_obj,
@@ skipping 207 matching lines @@
 
   friend class HeapSnapshotJSONSerializerEnumerator;
   friend class HeapSnapshotJSONSerializerIterator;
 
   DISALLOW_COPY_AND_ASSIGN(HeapSnapshotJSONSerializer);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_PROFILE_GENERATOR_H_