[filemanager] Open Downloads by default (instead of removable device).

chrome/browser/resources/file_manager/js/directory_model.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // If directory files changes too often, don't rescan directory more than once
 // per specified interval
 var SIMULTANEOUS_RESCAN_INTERVAL = 1000;
 // Used for operations that require almost instant rescan.
 var SHORT_RESCAN_INTERVAL = 100;
 
@@ skipping 789 matching lines @@
   function onLeafError(baseDirEntry, err) {
     // Usually, leaf does not exist, because it's just a suggested file name.
     if (err.code != FileError.NOT_FOUND_ERR)
       console.log('Unexpected error resolving default leaf: ' + err);
     changeDirectoryEntry(baseDirEntry, autoSelect, INITIAL, !EXISTS);
   }
 
   var onBaseError = function(err) {
     console.log('Unexpected error resolving default base "' +
                 baseName + '": ' + err);
-    if (path != '/' + DirectoryModel.DOWNLOADS_DIRECTORY) {
+    if (path != this.getDefaultDirectory()) {
       // Can't find the provided path, let's go to default one instead.
       resolveCallback(!EXISTS);
       if (!overridden)
         this.setupDefaultPath(opt_loadedCallback);
     } else {
       // Well, we can't find the downloads dir. Let's just show something,
       // or we will get an infinite recursion.
       changeDirectoryEntry(this.root_, opt_loadedCallback, INITIAL, !EXISTS);
     }
   }.bind(this);
 
   var onBaseFound = function(baseDirEntry) {
     if (!leafName) {
       // Default path is just a directory, cd to it and we're done.
       changeDirectoryEntry(baseDirEntry, autoSelect, INITIAL, !EXISTS);
       return;
     }
 
     util.resolvePath(this.root_, path,
                      onLeafFound.bind(this, baseDirEntry),
                      onLeafError.bind(this, baseDirEntry));
   }.bind(this);
 
   var root = this.root_;
-  if (baseName) {
-    root.getDirectory(
-        baseName, {create: false}, onBaseFound, onBaseError);
-  } else {
-    this.getDefaultDirectory_(function(defaultDir) {
-      baseName = defaultDir;
-      root.getDirectory(
-          baseName, {create: false}, onBaseFound, onBaseError);
-    });
-  }
+  if (!baseName)
+    baseName = this.getDefaultDirectory();
+  root.getDirectory(baseName, {create: false}, onBaseFound, onBaseError);
 };
 
 /**
  * @param {function} opt_callback Callback on done.
  */
 DirectoryModel.prototype.setupDefaultPath = function(opt_callback) {
-  var overridden = false;
-  function onExternalDirChange() {
-    overridden = true;
-  }
-  this.addEventListener('directory-changed', onExternalDirChange);
-
-  this.getDefaultDirectory_(function(path) {
-    this.removeEventListener('directory-changed', onExternalDirChange);
-    if (!overridden)
-      this.setupPath(path, opt_callback);
-  }.bind(this));
+  this.setupPath(this.getDefaultDirectory(), opt_callback);
 };
 
 /**
- * @private
- * @param {function(string)} callback Called with the path to directory.
+ * @return {string} The default directory.
  */
-DirectoryModel.prototype.getDefaultDirectory_ = function(callback) {
-  function onGetDirectoryComplete(entries, error) {
-    if (entries.length > 0)
-      callback(entries[0].fullPath);
-    else
-      callback('/' + DirectoryModel.DOWNLOADS_DIRECTORY);
-  }
-
-  // No preset given, find a good place to start.
-  // Check for removable devices, if there are none, go to Downloads.
-  util.readDirectory(this.root_, DirectoryModel.REMOVABLE_DIRECTORY,
-                     onGetDirectoryComplete);
+DirectoryModel.prototype.getDefaultDirectory = function() {
+  return '/' + DirectoryModel.DOWNLOADS_DIRECTORY;
 };
 
 /**
  * @param {string} name Filename.
  */
 DirectoryModel.prototype.selectEntry = function(name) {
   var dm = this.fileList_;
   for (var i = 0; i < dm.length; i++) {
     if (dm.item(i).name == name) {
       this.selectIndex(i);
@@ skipping 170 matching lines @@
     if (roots.item(index).fullPath == path)
       return index;
   }
   return -1;
 };
 
 /**
  * @private
  */
 DirectoryModel.prototype.updateRootsListSelection_ = function() {
-  this.rootsListSelection_.selectedIndex =
-      this.findRootsListItem_(this.rootPath);
+  var rootPath = DirectoryModel.getRootPath(this.currentDirEntry_.fullPath);
+  this.rootsListSelection_.selectedIndex = this.findRootsListItem_(rootPath);
 };
 
 /**
  * @private
  */
 DirectoryModel.prototype.updateReadonlyStatus_ = function() {
   switch (this.getRootType()) {
     case DirectoryModel.RootType.REMOVABLE:
       this.readonly_ = !!this.currentVolumeMetadata_.isReadOnly;
       break;
@@ skipping 51 matching lines @@
   // We never need to remove this attribute because even if the unmount fails
   // the onMountCompleted handler calls updateRoots which creates a new entry
   // object for this volume.
   entry.unmounting = true;
 
   // Re-place the entry into the roots data model to force re-rendering.
   this.rootsList_.splice(index, 1, entry);
 
   if (rootPath == this.rootPath) {
     // TODO(kaznacheev): Consider changing to the most recently used root.
-    this.changeDirectory('/' + DirectoryModel.DOWNLOADS_DIRECTORY);
+    this.changeDirectory(this.getDefaultDirectory());
   }
 };
 
 /**
  * @param {string} path Any path.
  * @return {string} The root path.
  */
 DirectoryModel.getRootPath = function(path) {
   var type = DirectoryModel.getRootType(path);
 
@@ skipping 144 matching lines @@
 /**
  * @private
  */
 DirectoryModel.Scanner.prototype.recordMetrics_ = function() {
   metrics.recordInterval('DirectoryScan');
   if (this.dir_.fullPath ==
       '/' + DirectoryModel.DOWNLOADS_DIRECTORY) {
     metrics.recordMediumCount('DownloadsCount', this.list_.length);
   }
 };